Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 279643002: Remove dead RenderLayerCompositor::setCompositingParent (Closed)

Created:
6 years, 7 months ago by esprehn
Modified:
6 years, 7 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink
Visibility:
Public.

Description

Remove dead RenderLayerCompositor::setCompositingParent This code is dead, we always pass a null parentLayer which causes us to early return. I think we were supposed to call childLayer->compositedLayerMapping()->childForSuperlayers()->removeFromParent() in the original design, but since r44876 [1] we always early return when the parentLayer is null, and that patch was back in 2009 so clearly the code is not needed. [1] http://src.chromium.org/viewvc/blink?revision=44876&view=revision R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173705

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M Source/core/rendering/compositing/RenderLayerCompositor.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -22 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
esprehn
6 years, 7 months ago (2014-05-09 00:02:29 UTC) #1
chrishtr
lgtm
6 years, 7 months ago (2014-05-09 01:08:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/279643002/1
6 years, 7 months ago (2014-05-09 01:09:56 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 02:19:59 UTC) #4
commit-bot: I haz the power
Change committed as 173705
6 years, 7 months ago (2014-05-09 02:59:06 UTC) #5
abarth-chromium
6 years, 7 months ago (2014-05-09 03:02:36 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/279643002/diff/1/Source/core/rendering/compos...
File Source/core/rendering/compositing/RenderLayerCompositor.cpp (left):

https://codereview.chromium.org/279643002/diff/1/Source/core/rendering/compos...
Source/core/rendering/compositing/RenderLayerCompositor.cpp:684: GraphicsLayer*
hostedLayer = childLayer->compositedLayerMapping()->childForSuperlayers();
Do parentForSublayers and childForSuperlayers still have clients?

Powered by Google App Engine
This is Rietveld 408576698