Stop renaming |at| method to maintain compatibility with STL algorithms.

Stop renaming |at| method to maintain compatibility with STL algorithms.

BUG=672902
Review-Url: https://codereview.chromium.org/2796413004
Cr-Commit-Position: refs/heads/master@{#462581}
Committed: https://chromium.googlesource.com/chromium/src/+/5ecbba9425dfba1578ec8e2ff884130a2a2d2b9e

[Łukasz Anforowicz, 2017-04-06 18:26:46]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-04-06 18:26:46]

dcheng@, could you PTAL?

pilgrim@ has kindly listed STL-like methods that shouldn't be renamed in
https://crbug.com/672902#c14.  It turns out that we only miss "at".  In
particular, things containing an underscore (like "push_back") should be already
taken care of:
1) there is an explicit check in IsBlacklistedFunctionName and
GuessNameForUnresolvedDependentNode
2) there is a test for "push_back" in
tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

[dcheng, 2017-04-06 18:29:10]

LGTM

Originally I was thinking that maybe we should limit this to the WTF namespace,
but I looked at matches for " at(" in Source and it seems like most of them
probably want STL-style naming.

[Łukasz Anforowicz, 2017-04-06 18:30:32]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 19:25:07]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491503432817760, "parent_rev":
"a9cdd67d441f3dfd2ec334edd678ea1a011caa64", "commit_rev":
"5ecbba9425dfba1578ec8e2ff884130a2a2d2b9e"}

[commit-bot: I haz the power, 2017-04-06 19:25:59]

Description was changed from

==========
Stop renaming |at| method to maintain compatibility with STL algorithms.

BUG=672902
==========

to

==========
Stop renaming |at| method to maintain compatibility with STL algorithms.

BUG=672902

Review-Url: https://codereview.chromium.org/2796413004
Cr-Commit-Position: refs/heads/master@{#462581}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ecbba9425dfba1578ec8e2ff884...
==========

[commit-bot: I haz the power, 2017-04-06 19:26:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ecbba9425dfba1578ec8e2ff884...