Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2796413003: Migrate WTF::HashTable::remove() to ::erase() (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, chromium-reviews, kinuko+watch, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::HashTable::remove() to ::erase() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2796413003 Cr-Commit-Position: refs/heads/master@{#462453} Committed: https://chromium.googlesource.com/chromium/src/+/bdb70266f313724bc2127961ff5e240a49a19114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/Source/platform/wtf/HashMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/HashSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/HashTable.h View 7 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/LinkedHashSet.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/ListHashSet.h View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pilgrim_google
3 years, 8 months ago (2017-04-05 18:40:30 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-05 22:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796413003/1
3 years, 8 months ago (2017-04-06 01:37:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/265872)
3 years, 8 months ago (2017-04-06 03:27:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796413003/1
3 years, 8 months ago (2017-04-06 12:17:39 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 13:57:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bdb70266f313724bc2127961ff5e...

Powered by Google App Engine
This is Rietveld 408576698