Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Issue 2796343004: ChromeOS OOBE: cr-network-list strings must be updated on UI language change. (Closed)

Created:
3 years, 8 months ago by Alexander Alekseev
Modified:
3 years, 8 months ago
Reviewers:
jdufault
CC:
chromium-reviews, ortuno+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: cr-network-list strings must be updated on UI language change. BUG=707487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2796343004 Cr-Commit-Position: refs/heads/master@{#462722} Committed: https://chromium.googlesource.com/chromium/src/+/261a0b276f6d7725877f735cc516d95182e5e360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_network.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Alexander Alekseev
Please review.
3 years, 8 months ago (2017-04-06 01:53:37 UTC) #3
jdufault
lgtm
3 years, 8 months ago (2017-04-06 21:07:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796343004/1
3 years, 8 months ago (2017-04-06 23:57:12 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 01:06:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/261a0b276f6d7725877f735cc516...

Powered by Google App Engine
This is Rietveld 408576698