Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Unified Diff: components/history/core/browser/history_service.h

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_service.h
diff --git a/components/history/core/browser/history_service.h b/components/history/core/browser/history_service.h
index c89868c9b4f974503c737d8b635469b089cd8f10..a24b369f4c3270f594e50f860b3fcf9d5d6523de 100644
--- a/components/history/core/browser/history_service.h
+++ b/components/history/core/browser/history_service.h
@@ -676,21 +676,9 @@ class HistoryService : public syncer::SyncableService, public KeyedService {
const favicon_base::FaviconResultsCallback& callback,
base::CancelableTaskTracker* tracker);
- // Used by FaviconService to find the first favicon bitmap whose width and
- // height are greater than that of |minimum_size_in_pixels|. This searches
- // for icons by IconType. Each element of |icon_types| is a bitmask of
- // IconTypes indicating the types to search for.
- // If the largest icon of |icon_types[0]| is not larger than
- // |minimum_size_in_pixel|, the next icon types of
- // |icon_types| will be searched and so on.
- // If no icon is larger than |minimum_size_in_pixel|, the largest one of all
- // icon types in |icon_types| is returned.
- // This feature is especially useful when some types of icon is preferred as
- // long as its size is larger than a specific value.
+ // Used by FaviconService to find the largest bitmap for |page_url|.
base::CancelableTaskTracker::TaskId GetLargestFaviconForURL(
const GURL& page_url,
- const std::vector<int>& icon_types,
- int minimum_size_in_pixels,
const favicon_base::FaviconRawBitmapCallback& callback,
base::CancelableTaskTracker* tracker);
« no previous file with comments | « components/history/core/browser/history_backend_unittest.cc ('k') | components/history/core/browser/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698