Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: components/history/core/browser/history_service.cc

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_service.cc
diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc
index b9ebe00521add936bbbd9d22696e8edf2421a08b..8f0095155353e3a6b5b60a3db9b66d8e80b08970 100644
--- a/components/history/core/browser/history_service.cc
+++ b/components/history/core/browser/history_service.cc
@@ -540,8 +540,6 @@ base::CancelableTaskTracker::TaskId HistoryService::GetFaviconsForURL(
base::CancelableTaskTracker::TaskId HistoryService::GetLargestFaviconForURL(
const GURL& page_url,
- const std::vector<int>& icon_types,
- int minimum_size_in_pixels,
const favicon_base::FaviconRawBitmapCallback& callback,
base::CancelableTaskTracker* tracker) {
DCHECK(backend_task_runner_) << "History service being called after cleanup";
@@ -551,7 +549,7 @@ base::CancelableTaskTracker::TaskId HistoryService::GetLargestFaviconForURL(
return tracker->PostTaskAndReply(
backend_task_runner_.get(), FROM_HERE,
base::Bind(&HistoryBackend::GetLargestFaviconForURL, history_backend_,
- page_url, icon_types, minimum_size_in_pixels, result),
+ page_url, result),
base::Bind(&RunWithFaviconResult, callback, base::Owned(result)));
}
« no previous file with comments | « components/history/core/browser/history_service.h ('k') | ios/chrome/app/spotlight/spotlight_manager_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698