components/favicon/core/favicon_service.h - Issue 2796343003: Remove preferences among favicon types when choosing large icons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_service.h

Issue 2796343003: Remove preferences among favicon types when choosing large icons

Patch Set: Rebased. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_service.h

diff --git a/components/favicon/core/favicon_service.h b/components/favicon/core/favicon_service.h

index 8ac749f8419265319ec846df441256272f6d6e6b..e8e81a79de4d98f23489a52740335f6e2a2968d6 100644

--- a/components/favicon/core/favicon_service.h

+++ b/components/favicon/core/favicon_service.h

@@ -102,11 +102,9 @@ class FaviconService : public KeyedService {

const favicon_base::FaviconRawBitmapCallback& callback,

base::CancelableTaskTracker* tracker) = 0;

- // See HistoryService::GetLargestFaviconForPageURL().

+ // See HistoryService::GetLargestFaviconForURL().

virtual base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL(

const GURL& page_url,

- const std::vector<int>& icon_types,

- int minimum_size_in_pixels,

const favicon_base::FaviconRawBitmapCallback& callback,

base::CancelableTaskTracker* tracker) = 0;