Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2796343002: [builtins] Implement %TypedArray%.prototype.{reduce,reduceRight} in the CSA (Closed)

Created:
3 years, 8 months ago by Tobias Tebbi
Modified:
3 years, 8 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Implement %TypedArray%.prototype.{reduce,reduceRight} in the CSA R=danno@chromium.org Review-Url: https://codereview.chromium.org/2796343002 Cr-Commit-Position: refs/heads/master@{#44558} Committed: https://chromium.googlesource.com/v8/v8/+/2aaacddd4dd6d0cfcc56af9d3f36044d9d21f1a6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -13 lines) Patch
M src/bootstrapper.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins/builtins-array-gen.cc View 1 10 chunks +60 lines, -13 lines 0 comments Download
M src/builtins/builtins-definitions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Tobias Tebbi
https://codereview.chromium.org/2796343002/diff/1/src/builtins/builtins-array-gen.cc File src/builtins/builtins-array-gen.cc (left): https://codereview.chromium.org/2796343002/diff/1/src/builtins/builtins-array-gen.cc#oldcode17 src/builtins/builtins-array-gen.cc:17: a_(this, MachineRepresentation::kTagged, SmiConstant(0)), I removed these defaults because we ...
3 years, 8 months ago (2017-04-05 11:53:05 UTC) #1
danno
lgtm
3 years, 8 months ago (2017-04-07 08:36:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796343002/1
3 years, 8 months ago (2017-04-07 13:26:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/25697) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-07 13:28:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796343002/20001
3 years, 8 months ago (2017-04-07 13:44:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/25702) v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-07 13:45:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796343002/20001
3 years, 8 months ago (2017-04-11 10:36:53 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 11:02:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2aaacddd4dd6d0cfcc56af9d3f36044d9d2...

Powered by Google App Engine
This is Rietveld 408576698