Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2796313002: Update WPT web-animations test expectations (Closed)

Created:
3 years, 8 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 8 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WPT web-animations test expectations The auto import of the web platform tests has added several lines to TestExpectations for the web-animations suite. This patch replaces several of these with more specific -expected.txt files and moves the other new lines from the tracking bug for untriaged failures to the existing tracking bug for these test failures. BUG=626703, 600248 Review-Url: https://codereview.chromium.org/2796313002 Cr-Commit-Position: refs/heads/master@{#462345} Committed: https://chromium.googlesource.com/chromium/src/+/758647775c72508a620bd1ba203828d46bd46cb0

Patch Set 1 #

Patch Set 2 : Tweak expectations based on flakiness dashboard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 3 chunks +5 lines, -19 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/spacing-keyframes-filters-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/spacing-keyframes-shapes-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/spacing-keyframes-transform-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/combining-effects/effect-composition-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animation/constructor-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/Animation/finished-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/composite-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/copy-contructor-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffectReadOnly/copy-contructor-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animations/set-the-target-effect-of-an-animation-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
suzyh_UTC10 (ex-contributor)
+meade for review cc qyearsley FYI
3 years, 8 months ago (2017-04-05 22:52:16 UTC) #8
alancutter (OOO until 2018)
lgtm
3 years, 8 months ago (2017-04-06 01:20:13 UTC) #12
meade_UTC10
lgtm
3 years, 8 months ago (2017-04-06 03:30:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796313002/20001
3 years, 8 months ago (2017-04-06 03:38:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/758647775c72508a620bd1ba203828d46bd46cb0
3 years, 8 months ago (2017-04-06 03:43:08 UTC) #18
qyearsley
3 years, 8 months ago (2017-04-06 17:00:13 UTC) #19
Message was sent while issue was closed.
On 2017/04/06 at 03:43:08, commit-bot wrote:
> Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/758647775c72508a620bd1ba2038...

Excellent, thanks :-)

Powered by Google App Engine
This is Rietveld 408576698