Associated Message Validation

Add validation conformance tests for associated interfaces. Add encoding, decoding and validation for associated interfaces.

Modified Mojo js tmpls to support associated interfaces (encode, decode, default values, validation).
Added codec.AssociatedInterfacePtrInfo and codec.AssociatedInterfaceRequest.
Modify validator.js  validateMessageHeader() to validate v2 messages.
Add to validator.js validateAssociatedInterface & validateAssociatedInterfaceRequest.
Modify validator.js validateArray(...) to validate array of associated InterfacePtrInfo/InterfaceRequest.

BUG=695635
Review-Url: https://codereview.chromium.org/2796253002
Cr-Commit-Position: refs/heads/master@{#464478}
Committed: https://chromium.googlesource.com/chromium/src/+/336e07d78b075a81a7debb521f167bd4dfd93ade

[wangjimmy, 2017-04-05 07:29:13]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 07:29:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 07:33:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[wangjimmy, 2017-04-05 07:49:50]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 07:49:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 08:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 08:29:11]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[wangjimmy, 2017-04-05 08:52:32]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 08:52:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 09:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 09:29:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[wangjimmy, 2017-04-05 19:46:02]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 19:46:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 21:14:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:14:53]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-04-05 22:37:30]

Description was changed from

==========
Associated Message Validation

BUG=
==========

to

==========
Add validation conformance tests for associated interfaces. Add encoding,
decoding and validation for associated interfaces.

Modified Mojo js tmpls to support associated interfaces (encode, decode, default
values, validation).
Added codec.AssociatedInterfacePtrInfo and codec.AssociatedInterfaceRequest.
Modify validator.js  validateMessageHeader() to validate v2 messages.
Add to validator.js validateAssociatedInterface &
validateAssociatedInterfaceRequest.
Modify validator.js validateArray(...) to validate array of associated
InterfacePtrInfo/InterfaceRequest.

BUG=695635
==========

[wangjimmy, 2017-04-05 22:38:57]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 22:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-05 22:45:03]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 22:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-06 04:54:22]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 04:54:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 06:53:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 06:53:04]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-04-10 18:02:38]

wangjimmy@chromium.org changed reviewers:
+ eugenebut@chromium.org

[wangjimmy, 2017-04-10 18:02:39]

Hi Eugune, PTAL at ios/. Thank you

[wangjimmy, 2017-04-10 18:03:50]

wangjimmy@chromium.org changed reviewers:
+ jam@chromium.org

[wangjimmy, 2017-04-10 18:03:51]

Hi John, PTAL at content/

[wangjimmy, 2017-04-10 18:31:26]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 18:32:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:39:31]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-04-10 20:31:59]

wangjimmy@chromium.org changed reviewers:
+ rockot@google.com

[wangjimmy, 2017-04-10 20:32:00]

Hi Ken, PTAL at extensions/ and mojo/.

[Eugene But (OOO till 7-30), 2017-04-10 20:48:37]

ios lgtm

[Ken Rockot(use gerrit already), 2017-04-10 21:51:15]

rockot@chromium.org changed reviewers:
+ rockot@chromium.org
- rockot@google.com

[Ken Rockot(use gerrit already), 2017-04-10 22:20:17]

Nice work! LGTM

https://codereview.chromium.org/2796253002/diff/140001/mojo/public/js/codec.js
File mojo/public/js/codec.js (right):

https://codereview.chromium.org/2796253002/diff/140001/mojo/public/js/codec.j...
mojo/public/js/codec.js:470: kMessageV2HeaderSize-8);
nit: Perhaps this should be its own "constant" like
kMessage2HeaderSizeWithoutInterfaceIds? Maybe with a brief comment explaining
what it is?

[wangjimmy, 2017-04-11 00:19:54]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 00:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-11 00:21:24]

https://codereview.chromium.org/2796253002/diff/140001/mojo/public/js/codec.js
File mojo/public/js/codec.js (right):

https://codereview.chromium.org/2796253002/diff/140001/mojo/public/js/codec.j...
mojo/public/js/codec.js:470: kMessageV2HeaderSize-8);
On 2017/04/10 22:20:17, Ken Rockot wrote:
> nit: Perhaps this should be its own "constant" like
> kMessage2HeaderSizeWithoutInterfaceIds? Maybe with a brief comment explaining
> what it is?

var messageV2PayloadInterfaceIdsPointer = kMessageV2HeaderSize - 8;
var decoder = new Decoder(this.buffer, this.handles,
    messageV2PayloadInterfaceIdsPointer);

Used a variable to describe what the value calculated is.

[jam, 2017-04-11 01:13:13]

lgtm

[wangjimmy, 2017-04-11 01:31:14]

wangjimmy@chromium.org changed reviewers:
+ yzshen@chromium.org

[commit-bot: I haz the power, 2017-04-11 01:31:18]

The CQ bit was unchecked by commit-bot@chromium.org

[wangjimmy, 2017-04-11 01:31:18]

Hi Yuzhu, PTAL at mojo/. Thank you

[commit-bot: I haz the power, 2017-04-11 01:31:19]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-04-11 06:23:10]

yzshen@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2017-04-11 06:23:11]

Thanks! It mostly looks good. Just a few nits.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.js
File mojo/public/js/codec.js (right):

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.j...
mojo/public/js/codec.js:35: var kMessageWithRequestIDHeaderSize = 32;
Please change kMessageHeaderSize and kMessageWithRequestIDHeaderSize to
kMessageV0HeaderSize and kMessageV1HeaderSize, respectively.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.j...
mojo/public/js/codec.js:469: var messageV2PayloadInterfaceIdsPointer =
kMessageV2HeaderSize - 8;
Please consider defining kMessagePayloadInterfaceIdsPointerOffset (unfortunately
the name is pretty long), similar to kMessageInterfaceIdOffset etc.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.j...
mojo/public/js/codec.js:869: AssociatedInterfacePtrInfo.decode;
Where are the definition of the decode/encode functions? (And the same comment
for AssociatedInterfaceRequest.)

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
File mojo/public/js/validator.js (right):

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:134: get: function() { return
this.message.getPayloadInterfaceIds().length; }
getPayloadInterfaceIds() may throw exception (if message version < 2) or return
null (if message version == 2 but the message has a null interface ids array)
which also cause exception.

Does it make sense to return 0 for both this cases?
That would be more consistent because the validation code doesn't throw
exceptions for validation errors.

(Please also see my comment on line 180)

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:180: index >= this.associatedHandleIndexLimit) {
Imagine the message has a null payload interface IDs array, and it has an
associated interface/request field which has the index value 0. In this case,
this method is supposed to return false, instead of throwing exception by
associatedHandleIndexLimit.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:299: (version > 1 &&
To be exact:
... ||
(version == 2 && numBytes == codec.kMessageV2HeaderSize) ||
(version > 2 && numBytes >= codec.kMessageV2HeaderSize)

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:317: if (this.message.getPayloadInterfaceIds()) {
- I think you need to validate the array because trying to decode it?
An example of how to do the validation:
https://cs.chromium.org/chromium/src/out/Debug/gen/mojo/public/interfaces/bin...

- Instead of calling getPayloadInterfaceIds() multiple times, please cache the
result.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_js_generator.py (right):

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_js_generator.py:141: else
"AssociatedInterfacePtrInfo")
"else" should align with "if" on the previous line, or maybe 4 more spaces than
"NullableAssociatedInterfacePtrInfo" on the previous line.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_js_generator.py:145: else
"AssociatedInterfaceRequest")
ditto.

[wangjimmy, 2017-04-12 00:12:55]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 00:13:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-12 00:24:18]

The CQ bit was unchecked by wangjimmy@chromium.org

[wangjimmy, 2017-04-12 00:25:30]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 00:26:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangjimmy, 2017-04-12 00:26:17]

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.js
File mojo/public/js/codec.js (right):

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.j...
mojo/public/js/codec.js:35: var kMessageWithRequestIDHeaderSize = 32;
On 2017/04/11 06:23:11, yzshen1 wrote:
> Please change kMessageHeaderSize and kMessageWithRequestIDHeaderSize to
> kMessageV0HeaderSize and kMessageV1HeaderSize, respectively.

Done.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.j...
mojo/public/js/codec.js:469: var messageV2PayloadInterfaceIdsPointer =
kMessageV2HeaderSize - 8;
On 2017/04/11 06:23:11, yzshen1 wrote:
> Please consider defining kMessagePayloadInterfaceIdsPointerOffset
(unfortunately
> the name is pretty long), similar to kMessageInterfaceIdOffset etc.

Done.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/codec.j...
mojo/public/js/codec.js:869: AssociatedInterfacePtrInfo.decode;
On 2017/04/11 06:23:11, yzshen1 wrote:
> Where are the definition of the decode/encode functions? (And the same comment
> for AssociatedInterfaceRequest.)

Done. Removed the Nullable encode/decode for Associated interfaces/request.
Encode and decode will be added in a later patch. Since validation tests do not
test them

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
File mojo/public/js/validator.js (right):

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:134: get: function() { return
this.message.getPayloadInterfaceIds().length; }
On 2017/04/11 06:23:11, yzshen1 wrote:
> getPayloadInterfaceIds() may throw exception (if message version < 2) or
return
> null (if message version == 2 but the message has a null interface ids array)
> which also cause exception.
> 
> Does it make sense to return 0 for both this cases?
> That would be more consistent because the validation code doesn't throw
> exceptions for validation errors.
> 
> (Please also see my comment on line 180)

Done.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:180: index >= this.associatedHandleIndexLimit) {
On 2017/04/11 06:23:11, yzshen1 wrote:
> Imagine the message has a null payload interface IDs array, and it has an
> associated interface/request field which has the index value 0. In this case,
> this method is supposed to return false, instead of throwing exception by
> associatedHandleIndexLimit.

Acknowledged.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:299: (version > 1 &&
On 2017/04/11 06:23:11, yzshen1 wrote:
> To be exact:
> ... ||
> (version == 2 && numBytes == codec.kMessageV2HeaderSize) ||
> (version > 2 && numBytes >= codec.kMessageV2HeaderSize)

Done.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/js/validat...
mojo/public/js/validator.js:317: if (this.message.getPayloadInterfaceIds()) {
On 2017/04/11 06:23:11, yzshen1 wrote:
> - I think you need to validate the array because trying to decode it?
> An example of how to do the validation:
>
https://cs.chromium.org/chromium/src/out/Debug/gen/mojo/public/interfaces/bin...
> 
> - Instead of calling getPayloadInterfaceIds() multiple times, please cache the
> result.

Done.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_js_generator.py (right):

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_js_generator.py:141: else
"AssociatedInterfacePtrInfo")
On 2017/04/11 06:23:11, yzshen1 wrote:
> "else" should align with "if" on the previous line, or maybe 4 more spaces
than
> "NullableAssociatedInterfacePtrInfo" on the previous line.

Done.

https://codereview.chromium.org/2796253002/diff/160001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_js_generator.py:145: else
"AssociatedInterfaceRequest")
On 2017/04/11 06:23:11, yzshen1 wrote:
> ditto.

Done.

[yzshen1, 2017-04-12 00:50:33]

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/codec.js
File mojo/public/js/codec.js (right):

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/codec.j...
mojo/public/js/codec.js:41: var kMessagePayloadInterfaceIdsPointerOffset =
kMessageV2HeaderSize - 8;
Please move this line to be below line 434

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/codec.j...
mojo/public/js/codec.js:935: exports.kMessagePayloadInterfaceIdsPointerOffset =
Is it necessary to export this value?

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
File mojo/public/js/validator.js (right):

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
mojo/public/js/validator.js:132: var payloadInterfaceIds =
this.message.getPayloadInterfaceIds();
Can we cache this value instead of computing it everytime?

Maybe we can cache the result of getPayloadInterfaceIds() during
Validator.prototype.validateMessageHeader()? After we do the necessary
validation?

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
mojo/public/js/validator.js:320: var payloadInterfaceIds =
this.message.getPayloadInterfaceIds();
Reading the array must be done *after* the validation (currently it is on line
332).

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
mojo/public/js/validator.js:325: [payloadInterfaceIds.length], 0);
Please use [0] instead of [payloadInterfaceIds.length], it means "any size is
okay".

[commit-bot: I haz the power, 2017-04-12 02:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:18:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[wangjimmy, 2017-04-12 04:51:49]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:52:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 06:39:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 06:39:39]

Dry run: This issue passed the CQ dry run.

[wangjimmy, 2017-04-12 18:58:17]

The CQ bit was checked by wangjimmy@chromium.org to run a CQ dry run

[wangjimmy, 2017-04-12 18:58:26]

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/codec.js
File mojo/public/js/codec.js (right):

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/codec.j...
mojo/public/js/codec.js:41: var kMessagePayloadInterfaceIdsPointerOffset =
kMessageV2HeaderSize - 8;
On 2017/04/12 00:50:33, yzshen1 wrote:
> Please move this line to be below line 434

Done.

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/codec.j...
mojo/public/js/codec.js:935: exports.kMessagePayloadInterfaceIdsPointerOffset =
On 2017/04/12 00:50:33, yzshen1 wrote:
> Is it necessary to export this value?

Yes, I use it as the offset for validateArrayPointer in validator.js when
validating the payloadInterfaceIds. I can calculate it using
kMessageV2HeaderSize - 8; if that's preferred.

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
File mojo/public/js/validator.js (right):

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
mojo/public/js/validator.js:132: var payloadInterfaceIds =
this.message.getPayloadInterfaceIds();
On 2017/04/12 00:50:33, yzshen1 wrote:
> Can we cache this value instead of computing it everytime?
> 
> Maybe we can cache the result of getPayloadInterfaceIds() during
> Validator.prototype.validateMessageHeader()? After we do the necessary
> validation?

Done.

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
mojo/public/js/validator.js:320: var payloadInterfaceIds =
this.message.getPayloadInterfaceIds();
On 2017/04/12 00:50:33, yzshen1 wrote:
> Reading the array must be done *after* the validation (currently it is on line
> 332).

Done.

https://codereview.chromium.org/2796253002/diff/200001/mojo/public/js/validat...
mojo/public/js/validator.js:325: [payloadInterfaceIds.length], 0);
On 2017/04/12 00:50:33, yzshen1 wrote:
> Please use [0] instead of [payloadInterfaceIds.length], it means "any size is
> okay".

Done.

[commit-bot: I haz the power, 2017-04-12 18:59:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 20:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 20:34:08]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-04-13 18:18:55]

lgtm

[wangjimmy, 2017-04-13 18:35:16]

The CQ bit was checked by wangjimmy@chromium.org

[wangjimmy, 2017-04-13 18:35:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
eugenebut@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2796253002/#ps240001
(title: "Validate payloadInterfaceIds before getting it. Use [0] for dimensions
for validateArrayPointer. Ca…")

[commit-bot: I haz the power, 2017-04-13 18:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 18:46:36]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1492108516385460,
"parent_rev": "fde00dd77cc64eaf7080bd1a693ff89a64e54cac", "commit_rev":
"336e07d78b075a81a7debb521f167bd4dfd93ade"}

[commit-bot: I haz the power, 2017-04-13 18:47:30]

Description was changed from

==========
Add validation conformance tests for associated interfaces. Add encoding,
decoding and validation for associated interfaces.

Modified Mojo js tmpls to support associated interfaces (encode, decode, default
values, validation).
Added codec.AssociatedInterfacePtrInfo and codec.AssociatedInterfaceRequest.
Modify validator.js  validateMessageHeader() to validate v2 messages.
Add to validator.js validateAssociatedInterface &
validateAssociatedInterfaceRequest.
Modify validator.js validateArray(...) to validate array of associated
InterfacePtrInfo/InterfaceRequest.

BUG=695635
==========

to

==========
Add validation conformance tests for associated interfaces. Add encoding,
decoding and validation for associated interfaces.

Modified Mojo js tmpls to support associated interfaces (encode, decode, default
values, validation).
Added codec.AssociatedInterfacePtrInfo and codec.AssociatedInterfaceRequest.
Modify validator.js  validateMessageHeader() to validate v2 messages.
Add to validator.js validateAssociatedInterface &
validateAssociatedInterfaceRequest.
Modify validator.js validateArray(...) to validate array of associated
InterfacePtrInfo/InterfaceRequest.

BUG=695635

Review-Url: https://codereview.chromium.org/2796253002
Cr-Commit-Position: refs/heads/master@{#464478}
Committed:
https://chromium.googlesource.com/chromium/src/+/336e07d78b075a81a7debb521f16...
==========

[commit-bot: I haz the power, 2017-04-13 18:47:32]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/336e07d78b075a81a7debb521f16...