Add isPromise V8 extras util

Add isPromise V8 extras util

This is used by streams in
https://streams.spec.whatwg.org/commit-snapshots/1375e266b2fe8246bd95cb9d8a49876ba9359dc9/#rs-pipe-through

This also fixes an omission in a6e635d6929c77e10c45ae069b15003b3f1cf73a
that did not properly update the
%OptimizeObjectForAddingMultipleProperties call in prologue.js.

BUG=chromium:668951
R=gsathya@chromium.org,littledan@chromium.org

Review-Url: https://codereview.chromium.org/2796243002
Cr-Commit-Position: refs/heads/master@{#44442}
Committed: https://chromium.googlesource.com/v8/v8/+/0d25fee3089c1084356054631ac9967c3844a97e

[gsathya, 2017-04-05 23:29:31]

lgtm

https://codereview.chromium.org/2796243002/diff/1/test/cctest/test-extra.js
File test/cctest/test-extra.js (right):

https://codereview.chromium.org/2796243002/diff/1/test/cctest/test-extra.js#n...
test/cctest/test-extra.js:98: thenableIsPromise: v8.isPromise({ then() { } }) 
// should be fase
nit: false

[domenic, 2017-04-06 05:15:26]

The CQ bit was checked by domenic@chromium.org

[domenic, 2017-04-06 05:15:27]

The patchset sent to the CQ was uploaded after l-g-t-m from gsathya@chromium.org
Link to the patchset: https://codereview.chromium.org/2796243002/#ps20001
(title: "Fix typo")

[commit-bot: I haz the power, 2017-04-06 05:15:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 05:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 05:18:44]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38527)

[domenic, 2017-04-06 05:21:44]

On 2017/04/06 at 05:18:44, commit-bot wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/38527)

(Needs OWNER lgtm, will wait for littledan.)

[Dan Ehrenberg, 2017-04-06 13:01:30]

lgtm

If this is needed to implement or optimize web specs, that's a little sad that
we don't export it to the web.

https://codereview.chromium.org/2796243002/diff/20001/src/js/prologue.js
File src/js/prologue.js (right):

https://codereview.chromium.org/2796243002/diff/20001/src/js/prologue.js#newc...
src/js/prologue.js:171: %OptimizeObjectForAddingMultipleProperties(extrasUtils,
11);
Nit: If you switch to InstallFunctions or similar logic, you won't risk this
getting out of sync. But no need to block this patch on that cleanup--anyway,
the utils object uses the same pattern.

[domenic, 2017-04-06 13:15:11]

The CQ bit was checked by domenic@chromium.org

[commit-bot: I haz the power, 2017-04-06 13:15:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 13:16:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491484511376560,
"parent_rev": "8b380d518eed17b1475b9f4750349b482f418c69", "commit_rev":
"0d25fee3089c1084356054631ac9967c3844a97e"}

[domenic, 2017-04-06 13:16:39]

On 2017/04/06 at 13:01:30, littledan wrote:
> lgtm
> 
> If this is needed to implement or optimize web specs, that's a little sad that
we don't export it to the web.

It's a little bit of a special case: we want to mark the promise as handled, if
it's a native promise. Usually we just Promise.resolve(), in streams and in all
other web specs. We just have one instance where the return value is
author-controlled, so we have to check if it's a native promise before marking
it as handled.

[commit-bot: I haz the power, 2017-04-06 13:16:40]

Description was changed from

==========
Add isPromise V8 extras util

This is used by streams in
https://streams.spec.whatwg.org/commit-snapshots/1375e266b2fe8246bd95cb9d8a49...

This also fixes an omission in a6e635d6929c77e10c45ae069b15003b3f1cf73a
that did not properly update the
%OptimizeObjectForAddingMultipleProperties call in prologue.js.

BUG=chromium:668951
R=gsathya@chromium.org,littledan@chromium.org
==========

to

==========
Add isPromise V8 extras util

This is used by streams in
https://streams.spec.whatwg.org/commit-snapshots/1375e266b2fe8246bd95cb9d8a49...

This also fixes an omission in a6e635d6929c77e10c45ae069b15003b3f1cf73a
that did not properly update the
%OptimizeObjectForAddingMultipleProperties call in prologue.js.

BUG=chromium:668951
R=gsathya@chromium.org,littledan@chromium.org

Review-Url: https://codereview.chromium.org/2796243002
Cr-Commit-Position: refs/heads/master@{#44442}
Committed:
https://chromium.googlesource.com/v8/v8/+/0d25fee3089c1084356054631ac9967c384...
==========

[commit-bot: I haz the power, 2017-04-06 13:16:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0d25fee3089c1084356054631ac9967c384...