Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2796133002:
[subresource_filter] Don't store no-op rules in IndexedRuleset. (Closed)
|
Created:
3 years, 8 months ago by pkalinnikov Modified:
3 years, 8 months ago CC:
chromium-reviews, subresource-filter-reviews_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[subresource_filter] Don't store no-op rules in IndexedRuleset.
Currently there are more than 1000 URL rules wasting space because they are not
supported. These are a few rules with REGEXP pattern type, and lots of
popup-only filtering rules, as well as 500+ rules controlling activation of CSS
filtering.
This CL removes such rules from IndexedRuleset, reducing its size by ~75 kB.
BUG=708458
Review-Url: https://codereview.chromium.org/2796133002
Cr-Commit-Position: refs/heads/master@{#462397}
Committed: https://chromium.googlesource.com/chromium/src/+/c4b33b2fe691abd42aeeaf5489a68bd5b53b2e08
Patch Set 1 #Patch Set 2 : Update format version. #Patch Set 3 : Fix tests; add new tests. #
Depends on Patchset: Messages
Total messages: 27 (18 generated)
The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. BUG= ========== to ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 Kb. BUG= ==========
pkalinnikov@chromium.org changed reviewers: + csharrison@chromium.org, engedy@chromium.org
PTAL.
The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 Kb. BUG= ========== to ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 Kb. BUG= ==========
Could you add a BUG= (is there a tracking bug for keeping indexed ruleset lean?) Also, a test would be nice to ensure those don't get included.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2017/04/04 17:15:50, Charlie Harrison wrote: > Could you add a BUG= (is there a tracking bug for keeping indexed ruleset lean?) > > Also, a test would be nice to ensure those don't get included. +1 on both of these. Also, why is the `subdocument` test failing?
Description was changed from ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 Kb. BUG= ========== to ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 Kb. BUG=708458 ==========
Description was changed from ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 Kb. BUG=708458 ========== to ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 kB. BUG=708458 ==========
The CQ bit was checked by pkalinnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Addressed the concerns, thanks! PTAL again.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
It lgtm
Thanks! Balazs, can you also take a quick look?
On 2017/04/06 08:24:57, pkalinnikov wrote: > Thanks! Balazs, can you also take a quick look? Still LGTM.
The CQ bit was checked by pkalinnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491467801500370,
"parent_rev": "0321c8f50c735c4dda344c32358e44df834872a8", "commit_rev":
"c4b33b2fe691abd42aeeaf5489a68bd5b53b2e08"}
Message was sent while issue was closed.
Description was changed from ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 kB. BUG=708458 ========== to ========== [subresource_filter] Don't store no-op rules in IndexedRuleset. Currently there are more than 1000 URL rules wasting space because they are not supported. These are a few rules with REGEXP pattern type, and lots of popup-only filtering rules, as well as 500+ rules controlling activation of CSS filtering. This CL removes such rules from IndexedRuleset, reducing its size by ~75 kB. BUG=708458 Review-Url: https://codereview.chromium.org/2796133002 Cr-Commit-Position: refs/heads/master@{#462397} Committed: https://chromium.googlesource.com/chromium/src/+/c4b33b2fe691abd42aeeaf5489a6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/c4b33b2fe691abd42aeeaf5489a6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
