Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2796053002: Revert "Skip flaky debug-scopes test" (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Skip flaky debug-scopes test" This reverts 1c1edda7db2c97ca80570038cae6daa304a9dcc0. I can't reproduce the flakes locally anymore, let's see if this sticks. BUG=v8:5619 Review-Url: https://codereview.chromium.org/2796053002 Cr-Commit-Position: refs/heads/master@{#44381} Committed: https://chromium.googlesource.com/v8/v8/+/10e77dfbaf0bdd8d6ab9202fff1994cf5ce99b5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/debugger/debugger.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 8 months ago (2017-04-04 13:26:58 UTC) #6
Yang
lgtm
3 years, 8 months ago (2017-04-04 13:59:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2796053002/1
3 years, 8 months ago (2017-04-04 14:01:32 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 14:27:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/10e77dfbaf0bdd8d6ab9202fff1994cf5ce...

Powered by Google App Engine
This is Rietveld 408576698