Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2796033003:
New checks for Java version against Maven files. (Closed)
|
Created:
3 years, 8 months ago by The one and only Dr. Crash Modified:
3 years, 8 months ago CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org, dkalin1, dpapad, Devlin, fukino Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionNew checks for Java version against Maven files.
Fix version check of Java and JDK to be 1.7 or above.
BUG=707043
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2796033003
Cr-Commit-Position: refs/heads/master@{#461776}
Committed: https://chromium.googlesource.com/chromium/src/+/de6533cf19916679011872eeb9d359ce857c5308
Patch Set 1 #
Total comments: 1
Patch Set 2 : Do not call test. #Messages
Total messages: 17 (8 generated)
Description was changed from ========== New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG=707043 TEST=manual ========== to ========== New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG=707043 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
drcrash@chromium.org changed reviewers: + dbeam@chromium.org
Description was changed from ========== New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG=707043 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG=707043 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
+fukino@, rdevlin.cronin@, dpapad@ as FYI drcrash@ figured out that the Maven build that we switched to a little while ago targets Java 7, so the host environment (namely our local machines) can be Java 8 and the bots will still be happy. yay! thanks drcrash@! https://codereview.chromium.org/2796033003/diff/1/third_party/closure_compile... File third_party/closure_compiler/roll_closure_compiler (right): https://codereview.chromium.org/2796033003/diff/1/third_party/closure_compile... third_party/closure_compiler/roll_closure_compiler:56: if ! test -r "$2"; then the shell styleguide says something about not using test but i'm too lazy to look up a better way (maybe [[ ! -r "$2" ]]?). https://google.github.io/styleguide/shell.xml#Test,_%5B_and_%5B%5B
lgtm
The CQ bit was checked by drcrash@google.com
On 2017/04/04 17:30:34, Dan Beam (slow) wrote: > +fukino@, rdevlin.cronin@, dpapad@ as FYI > > drcrash@ figured out that the Maven build that we switched to a little while ago > targets Java 7, so the host environment (namely our local machines) can be Java > 8 and the bots will still be happy. yay! > > thanks drcrash@! > > https://codereview.chromium.org/2796033003/diff/1/third_party/closure_compile... > File third_party/closure_compiler/roll_closure_compiler (right): > > https://codereview.chromium.org/2796033003/diff/1/third_party/closure_compile... > third_party/closure_compiler/roll_closure_compiler:56: if ! test -r "$2"; then > the shell styleguide says something about not using test but i'm too lazy to > look up a better way (maybe [[ ! -r "$2" ]]?). > > https://google.github.io/styleguide/shell.xml#Test,_%5B_and_%5B%5B Single bracket. Which really is an alias for test. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Ironically, I never use test myself but [ ... ] but decided against it somehow. I went for [ ! -r "$2" ] as I think it's more readable than ! [ -r "$2" ]
The CQ bit was checked by drcrash@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2796033003/#ps20001 (title: "Do not call test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491327428367360,
"parent_rev": "3e70c6e83884c8c84864e20b89c367df6562c711", "commit_rev":
"de6533cf19916679011872eeb9d359ce857c5308"}
Message was sent while issue was closed.
Description was changed from ========== New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG=707043 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== New checks for Java version against Maven files. Fix version check of Java and JDK to be 1.7 or above. BUG=707043 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2796033003 Cr-Commit-Position: refs/heads/master@{#461776} Committed: https://chromium.googlesource.com/chromium/src/+/de6533cf19916679011872eeb9d3... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/de6533cf19916679011872eeb9d3... |
