Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2795983003: Change //components/security_state/core deps to public_deps, add //url. (Closed)

Created:
3 years, 8 months ago by mattm
Modified:
3 years, 8 months ago
Reviewers:
palmer
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change //components/security_state/core deps to public_deps, add //url. BUG=none Review-Url: https://codereview.chromium.org/2795983003 Cr-Commit-Position: refs/heads/master@{#462220} Committed: https://chromium.googlesource.com/chromium/src/+/925f9caecc8b0b5bdb25aa8223c98c384f1dccbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/security_state/core/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
mattm
security_state.h includes headers from base, net, and url, therefore these should be public_deps. Example error ...
3 years, 8 months ago (2017-04-05 02:20:26 UTC) #4
palmer
lgtm
3 years, 8 months ago (2017-04-05 20:57:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795983003/1
3 years, 8 months ago (2017-04-05 21:09:14 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 21:24:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/925f9caecc8b0b5bdb25aa8223c9...

Powered by Google App Engine
This is Rietveld 408576698