Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2795863002: Disable Shell from connecting to prefs service (Closed)

Created:
3 years, 8 months ago by jonross
Modified:
3 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Shell from connecting to prefs service Currently, when using --mash, ash/shell is unable to connect to the prefs service which is provided by chrome. This change disables attempting to connect while in --mash mode. I will reenable once the root cause is found. TEST=ran chrome --mash to verify no boot crash BUG=707321 Review-Url: https://codereview.chromium.org/2795863002 Cr-Commit-Position: refs/heads/master@{#461551} Committed: https://chromium.googlesource.com/chromium/src/+/fe52253d07c2dfed2fc3cb60e6bc2baf5e386327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ash/shell.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
jonross
3 years, 8 months ago (2017-04-03 21:16:36 UTC) #2
James Cook
LGTM but please make sure you revert this promptly.
3 years, 8 months ago (2017-04-03 21:17:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795863002/1
3 years, 8 months ago (2017-04-03 21:21:40 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 22:06:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe52253d07c2dfed2fc3cb60e6bc...

Powered by Google App Engine
This is Rietveld 408576698