Remove pre-MD code from PowerStatusView.

Remove pre-MD code from PowerStatusView.

BUG=686335
TBR=derat@chromium.org

Review-Url: https://codereview.chromium.org/2795823002
Cr-Commit-Position: refs/heads/master@{#461735}
Committed: https://chromium.googlesource.com/chromium/src/+/489793be99ff049936b24953fc1fa133d8e0a210

[Evan Stade, 2017-04-03 19:21:22]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[Evan Stade, 2017-04-03 19:21:27]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:22:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:26:38]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tdanderson, 2017-04-03 22:18:02]

https://codereview.chromium.org/2795823002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/power/power_status_view.cc (left):

https://codereview.chromium.org/2795823002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/power/power_status_view.cc:58: if
(MaterialDesignController::UseMaterialDesignSystemIcons())
I think this is the last call site of
MaterialDesignController::UseMaterialDesignSystemIcons()

https://codereview.chromium.org/2795823002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/power/power_status_view.cc:66:
previous_battery_image_info_ = info;
Can you rebase this CL against the latest ToT? There seem to be some
inconsistencies in the diff (this member doesn't exist in ToT, for instance)

[Evan Stade, 2017-04-04 00:51:53]

https://codereview.chromium.org/2795823002/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/power/power_status_view.cc (left):

https://codereview.chromium.org/2795823002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/power/power_status_view.cc:58: if
(MaterialDesignController::UseMaterialDesignSystemIcons())
On 2017/04/03 22:18:02, tdanderson wrote:
> I think this is the last call site of
> MaterialDesignController::UseMaterialDesignSystemIcons()

Done.

https://codereview.chromium.org/2795823002/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/power/power_status_view.cc:66:
previous_battery_image_info_ = info;
On 2017/04/03 22:18:02, tdanderson wrote:
> Can you rebase this CL against the latest ToT? There seem to be some
> inconsistencies in the diff (this member doesn't exist in ToT, for instance)

Done.

[Evan Stade, 2017-04-04 00:51:57]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 00:52:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 01:42:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 01:42:11]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-04-04 14:51:15]

lgtm

https://codereview.chromium.org/2795823002/diff/40001/ash/common/system/chrom...
File ash/common/system/chromeos/power/power_status_view.cc (right):

https://codereview.chromium.org/2795823002/diff/40001/ash/common/system/chrom...
ash/common/system/chromeos/power/power_status_view.cc:36: // TODO(tdanderson):
Tweak padding values for material design.
This TODO can be removed, the layout is to spec.

[Evan Stade, 2017-04-04 15:19:21]

Description was changed from

==========
Remove pre-MD code from PowerStatusView.

BUG=686335
==========

to

==========
Remove pre-MD code from PowerStatusView.

BUG=686335
TBR=derat@chromium.org
==========

[Evan Stade, 2017-04-04 15:19:21]

estade@chromium.org changed reviewers:
+ derat@chromium.org

[Evan Stade, 2017-04-04 15:19:40]

tbr derat@ for material_design_controller.*

[Evan Stade, 2017-04-04 15:19:50]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-04-04 15:19:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2795823002/#ps60001
(title: "remove todo")

[commit-bot: I haz the power, 2017-04-04 15:20:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Daniel Erat, 2017-04-04 15:24:57]

lgtm

[commit-bot: I haz the power, 2017-04-04 15:59:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491319190223260,
"parent_rev": "62a56f6fcfea29c8dfd333156b0e704f0f1ff525", "commit_rev":
"489793be99ff049936b24953fc1fa133d8e0a210"}

[commit-bot: I haz the power, 2017-04-04 16:00:36]

Description was changed from

==========
Remove pre-MD code from PowerStatusView.

BUG=686335
TBR=derat@chromium.org
==========

to

==========
Remove pre-MD code from PowerStatusView.

BUG=686335
TBR=derat@chromium.org

Review-Url: https://codereview.chromium.org/2795823002
Cr-Commit-Position: refs/heads/master@{#461735}
Committed:
https://chromium.googlesource.com/chromium/src/+/489793be99ff049936b24953fc1f...
==========

[commit-bot: I haz the power, 2017-04-04 16:00:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/489793be99ff049936b24953fc1f...