Make run-webkit-tests work with virtual parent LayoutTest directories

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
index 73616d9f98d9fd018b8effd5e6da73b6a49e7b7b..634ed67704a9953199f1e433654723fb1f009d72 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
@@ -449,6 +449,7 @@ class PortTest(unittest.TestCase):
         tests = port.tests(['virtual/virtual_passes/passes'])
         self.assertNotIn('passes/text.html', tests)
         self.assertIn('virtual/virtual_passes/passes/test-virtual-passes.html', tests)
+        self.assertIn('virtual/virtual_passes/passes_two/test-virtual-passes.html', tests)

[qyearsley, 2017/04/05 22:47:07]

I think that this behavior is subtly inconsistent with the way that Port.tests
works for "real tests"... if the input paths do not have a "*", then the last
part of the path can't normally be just part of a directory name.

For example, right now there are the directories "fast/inline" and
"fast/inline-block". But if I run `run-webkit-tests fast/inline`, then only
those in "fast/inline" are run, and not those in "fast/inline-block".

So I think to test the desired behavior, we might want to do:

    tests = port.tests(['virtual/virtual_passes'])
    self.assertIn('virtual/virtual_passes/passes/test-virtual-passes.html',
tests)
    self.assertIn('virtual/virtual_passes/passes_two/test-virtual-passes.html',
tests)

and/or we might want to add the extra test as
tests.add('passes/two/test-virtual-passes.html') and then:

    tests = port.tests(['virtual/virtual_passes/passes'])
    self.assertIn('virtual/virtual_passes/passes/test-virtual-passes.html',
tests)
    self.assertIn('virtual/virtual_passes/passes/two/test-virtual-passes.html',
tests)

Does that make sense?

[Gleb Lanbin, 2017/04/06 17:27:32]

Done.

         self.assertNotIn('passes/test-virtual-passes.html', tests)
         self.assertNotIn('virtual/virtual_passes/passes/test-virtual-virtual/passes.html', tests)
         self.assertNotIn('virtual/virtual_passes/passes/virtual_passes/passes/test-virtual-passes.html', tests)