Make run-webkit-tests work with virtual parent LayoutTest directories

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
index 609f39ceb6e32150ab1eef0b67a8a11d16da63d8..5fb2fdf1e754e0ca270d414d4ee7768337a0eb84 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
@@ -1506,7 +1506,7 @@ class Port(object):
     def _virtual_tests_matching_paths(self, paths, suites):
         tests = []
         for suite in suites:
-            if any(p.startswith(suite.name) for p in paths):
+            if any(p.startswith(suite.name) for p in paths) or any(suite.name.startswith(p) for p in paths):

[qyearsley, 2017/04/05 22:47:07]

This is a bit difficult to think about without thinking of examples, for me...

So, suppose suites = [
  VirtualTestSuite(prefix='layout_ng', base='fast/block/basic',
args=['----enable-blink-features=LayoutNG']),
  VirtualTestSuite(prefix='layout_ng', base='fast/block/margin-collapse',
args=['----enable-blink-features=LayoutNG']),
] and paths = ['virtual/layout_ng/fast']

The the names of the suites are 

  virtual/layout_ng/fast/block/basic, and
  virtual/layout_ng/fast/block/margin-collapse

then any(p.startswith(suite.name) for p in paths) is False because both of the
suite names are longer than the given path, but any(suite.name.startswith(p) for
p in paths) is True because both of the suite names start with the given path.

So, this seems correct. :-)

[Gleb Lanbin, 2017/04/06 17:27:32]

Acknowledged.

                 self._populate_virtual_suite(suite)
             for test in suite.tests:
                 if any(test.startswith(p) for p in paths):