Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2795783002: [InputEvent] Update spec links for InputEvent(Init).idl (Closed)

Created:
3 years, 8 months ago by chongz
Modified:
3 years, 8 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Update spec links for InputEvent(Init).idl BUG=707913 Review-Url: https://codereview.chromium.org/2795783002 Cr-Commit-Position: refs/heads/master@{#461767} Committed: https://chromium.googlesource.com/chromium/src/+/75eb6237332971699fb1021b206ad049c1de30a4

Patch Set 1 #

Total comments: 2

Patch Set 2 : foolip@'s review: Put spec inside interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M third_party/WebKit/Source/core/events/InputEvent.idl View 1 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEventInit.idl View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
chongz
foolip@ PTAL, thanks!
3 years, 8 months ago (2017-04-03 20:44:56 UTC) #3
foolip
https://codereview.chromium.org/2795783002/diff/1/third_party/WebKit/Source/core/events/InputEvent.idl File third_party/WebKit/Source/core/events/InputEvent.idl (right): https://codereview.chromium.org/2795783002/diff/1/third_party/WebKit/Source/core/events/InputEvent.idl#newcode9 third_party/WebKit/Source/core/events/InputEvent.idl:9: // https://www.w3.org/TR/2017/WD-input-events-1-20170321/#interface-InputEvent Can you put this inside the interface ...
3 years, 8 months ago (2017-04-04 04:15:01 UTC) #4
chongz
foolip@ PTAL again, thanks! https://codereview.chromium.org/2795783002/diff/1/third_party/WebKit/Source/core/events/InputEvent.idl File third_party/WebKit/Source/core/events/InputEvent.idl (right): https://codereview.chromium.org/2795783002/diff/1/third_party/WebKit/Source/core/events/InputEvent.idl#newcode9 third_party/WebKit/Source/core/events/InputEvent.idl:9: // https://www.w3.org/TR/2017/WD-input-events-1-20170321/#interface-InputEvent On 2017/04/04 04:15:01, ...
3 years, 8 months ago (2017-04-04 15:33:21 UTC) #5
foolip
lgtm
3 years, 8 months ago (2017-04-04 15:59:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795783002/20001
3 years, 8 months ago (2017-04-04 15:59:43 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 17:30:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/75eb6237332971699fb1021b206a...

Powered by Google App Engine
This is Rietveld 408576698