MD Settings: adjust dialog style and scroll border visual

ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
index 14a5a866e2d4e464289772fb38d5256ff0eed063..e879eef5f1b80486323b44f27a95bafe8b29b29c 100644
--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
@@ -30,9 +30,8 @@
 
       .top-container {
         align-items: center;
-        border-bottom: 1px solid var(--divider-color);
         display: flex;
-        min-height: 52px;
+        min-height: 47px;
       }
 
       .title-container {
@@ -42,15 +41,22 @@
       }
 
       :host ::content .title {
-        font-size: 123.07%; /* (16px / 13px) * 100 */
+        font-size: 115.38%;  /* (15px / 13px) * 100 */
+        line-height: 1;
+        margin: 16px 0;
       }
 
       #close {
         --paper-icon-button: {
-          height: 40px;
-          width: 40px;
+          height: 36px;
+          width: 36px;
         };
-        -webkit-margin-end: 6px;
+
+        --layout-inline: {
+          display: flex;
+        };
+
+        -webkit-margin-end: 4px;
         /* <paper-icon-button> overrides --iron-icon-{height,width}, so this
          * padding essentially reduces 40x40 to 20x20. */
         padding: 10px;
@@ -66,31 +72,32 @@
       :host([show-scroll-borders]) .body-container {
         /* Prevent layout moving when border does appear. */
         border-bottom: 1px solid transparent;
+        border-top: 1px solid transparent;
       }
 
       :host([show-scroll-borders]) .body-container.bottom-scrollable {
         border-bottom: 1px solid var(--paper-grey-300);
       }
 
+      :host([show-scroll-borders]) .body-container.top-scrollable {
+        border-top: 1px solid var(--paper-grey-300);

[dpapad, 2017/04/06 23:50:55]

Can we declare a variable in :host{} and reuse it here and a few lines above?

:host {
  ...
  --border: 1px solid var(--paper-grey-300);
}

:host([show-scroll-borders]) .body-container.top-scrollable {
  border-top: var(--border);
}

[scottchen, 2017/04/07 22:55:54]

Done.

+      }
+
       :host ::content .body {
-        padding-bottom: 12px;
-        padding-top: 12px;
+        padding: 12px 0;
       }
 
       :host ::content .body,
       :host ::content .title {
-        -webkit-padding-end: 24px;
-        -webkit-padding-start: 24px;
+        padding: 0 16px;
         flex: 1;
       }
 
       :host ::content .button-container {
-        -webkit-padding-end: 16px;
-        -webkit-padding-start: 16px;
+        padding: 0 16px;

[dpapad, 2017/04/06 23:50:55]

Are you changing this just to compact things? Or does the top/bottom padding
needs to be zero?

The previous code was such that it did not specify padding top/bottom, on
purpose I think, but not sure. Either way, I see one case where a client is
specifying a padding-top at
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printi....
Can you verify that this is not breaking the layout of that dialog?

         display: flex;
         justify-content: flex-end;
-        margin-bottom: 12px;
-        margin-top: 12px;
+        margin: 16px 0;
       }
 
       :host ::content .button-container .cancel-button {
@@ -118,6 +125,7 @@
       </paper-icon-button>
     </div>
     <div class="body-container">
+      <span id="bodyTopMarker"></span>
       <content select=".body"></content>
       <span id="bodyBottomMarker"></span>
     </div>