MD Settings: adjust dialog style and scroll border visual

ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/html/assert.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/default-theme.html">
 
 <dom-module id="cr-dialog">
   <template>
     <style>
       :host {
@@ skipping 12 matching lines @@
         background-color: rgba(0, 0, 0, 0.6);
         bottom: 0;
         left: 0;
         position: fixed;
         right: 0;
         top: 0;
       }
 
       .top-container {
         align-items: center;
-        border-bottom: 1px solid var(--divider-color);
         display: flex;
-        min-height: 52px;
+        min-height: 47px;
       }
 
       .title-container {
         display: flex;
         flex: 1;
         outline: none;
       }
 
       :host ::content .title {
-        font-size: 123.07%; /* (16px / 13px) * 100 */
+        font-size: 115.38%;  /* (15px / 13px) * 100 */
+        line-height: 1;
+        margin: 16px 0;
       }
 
       #close {
         --paper-icon-button: {
-          height: 40px;
-          width: 40px;
+          height: 36px;
+          width: 36px;
         };
-        -webkit-margin-end: 6px;
+
+        --layout-inline: {
+          display: flex;
+        };
+
+        -webkit-margin-end: 4px;
         /* <paper-icon-button> overrides --iron-icon-{height,width}, so this
          * padding essentially reduces 40x40 to 20x20. */
         padding: 10px;
       }
 
       .body-container {
         display: flex;
         flex-direction: column;
         overflow: auto;
         @apply(--cr-dialog-body-container);
       }
 
       :host([show-scroll-borders]) .body-container {
         /* Prevent layout moving when border does appear. */
         border-bottom: 1px solid transparent;
+        border-top: 1px solid transparent;
       }
 
       :host([show-scroll-borders]) .body-container.bottom-scrollable {
         border-bottom: 1px solid var(--paper-grey-300);
       }
 
+      :host([show-scroll-borders]) .body-container.top-scrollable {
+        border-top: 1px solid var(--paper-grey-300);

[dpapad, 2017/04/06 23:50:55]

Can we declare a variable in :host{} and reuse it here and a few lines above?

:host {
  ...
  --border: 1px solid var(--paper-grey-300);
}

:host([show-scroll-borders]) .body-container.top-scrollable {
  border-top: var(--border);
}

[scottchen, 2017/04/07 22:55:54]

Done.

+      }
+
       :host ::content .body {
-        padding-bottom: 12px;
-        padding-top: 12px;
+        padding: 12px 0;
       }
 
       :host ::content .body,
       :host ::content .title {
-        -webkit-padding-end: 24px;
-        -webkit-padding-start: 24px;
+        padding: 0 16px;
         flex: 1;
       }
 
       :host ::content .button-container {
-        -webkit-padding-end: 16px;
-        -webkit-padding-start: 16px;
+        padding: 0 16px;

[dpapad, 2017/04/06 23:50:55]

Are you changing this just to compact things? Or does the top/bottom padding
needs to be zero?

The previous code was such that it did not specify padding top/bottom, on
purpose I think, but not sure. Either way, I see one case where a client is
specifying a padding-top at
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/printi....
Can you verify that this is not breaking the layout of that dialog?

         display: flex;
         justify-content: flex-end;
-        margin-bottom: 12px;
-        margin-top: 12px;
+        margin: 16px 0;
       }
 
       :host ::content .button-container .cancel-button {
         -webkit-margin-end: 8px;
         color: var(--paper-grey-600);
       }
 
       :host ::content .footer {
         border-bottom-left-radius: inherit;
         border-bottom-right-radius: inherit;
         margin: 0;
         padding: 16px 20px;
       }
 
       :host ::content .border-top-divider {
         border-top: 1px solid var(--divider-color);
       }
     </style>
     <div class="top-container">
       <div class="title-container" tabindex="-1">
         <content select=".title"></content>
       </div>
       <paper-icon-button icon="cr:clear" on-tap="cancel" id="close"
           aria-label$="[[closeText]]">
       </paper-icon-button>
     </div>
     <div class="body-container">
+      <span id="bodyTopMarker"></span>
       <content select=".body"></content>
       <span id="bodyBottomMarker"></span>
     </div>
     <content select=".button-container"></content>
     <content select=".footer"></content>
   </template>
   <script src="cr_dialog.js"></script>
 </dom-module>