Do not call GetDisplayDevice for older UPower versions.

Do not call GetDisplayDevice for older UPower versions.

On Linux, older versions of UPower did not have the GetDisplayDevice
method. Trying to call it generates log spam.

Modernize the modified file with base::MakeUnique while we are here.

BUG=695383
Review-Url: https://codereview.chromium.org/2795713003
Cr-Commit-Position: refs/heads/master@{#463358}
Committed: https://chromium.googlesource.com/chromium/src/+/91037c1a4a82985c652ac38826fd5b3fc6d56d91

[Lei Zhang, 2017-04-04 08:10:26]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 08:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-04 09:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 09:12:05]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-04-04 18:46:21]

thestig@chromium.org changed reviewers:
+ timvolodine@chromium.org

[Lei Zhang, 2017-04-08 00:14:08]

End of the week ping.

[timvolodine, 2017-04-10 12:50:58]

thanks for the fix! lgtm % comment below.

https://codereview.chromium.org/2795713003/diff/1/device/battery/battery_stat...
File device/battery/battery_status_manager_linux.cc (right):

https://codereview.chromium.org/2795713003/diff/1/device/battery/battery_stat...
device/battery/battery_status_manager_linux.cc:547: true);
nit: not sure if this is actually cleaner than the original implementation. The
AutoReset eventually resets the variable to the original value, which is
technically different from the previous implementation. Luckily the
notifying_battery_status_ cannot be true at this point as it would have returned
early due to preceding if-check, so in this case this is equivalent (but needed
checking that this is the case). I think I would prefer the original version
though..

[Lei Zhang, 2017-04-10 18:14:48]

https://codereview.chromium.org/2795713003/diff/1/device/battery/battery_stat...
File device/battery/battery_status_manager_linux.cc (right):

https://codereview.chromium.org/2795713003/diff/1/device/battery/battery_stat...
device/battery/battery_status_manager_linux.cc:547: true);
On 2017/04/10 12:50:58, timvolodine wrote:
> nit: not sure if this is actually cleaner than the original implementation.
The
> AutoReset eventually resets the variable to the original value, which is
> technically different from the previous implementation. Luckily the
> notifying_battery_status_ cannot be true at this point as it would have
returned
> early due to preceding if-check, so in this case this is equivalent (but
needed
> checking that this is the case). I think I would prefer the original version
> though..

You are right. It could have potentially started out as true. Reverted.

[Lei Zhang, 2017-04-10 18:14:55]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-04-10 18:14:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2795713003/#ps20001
(title: "Rebase, remove auto-reset")

[commit-bot: I haz the power, 2017-04-10 18:15:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:24:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491848095111590,
"parent_rev": "4d3963df0be6c3ba1fcf24789d40c85a58c7ea4f", "commit_rev":
"91037c1a4a82985c652ac38826fd5b3fc6d56d91"}

[commit-bot: I haz the power, 2017-04-10 19:25:32]

Description was changed from

==========
Do not call GetDisplayDevice for older UPower versions.

On Linux, older versions of UPower did not have the GetDisplayDevice
method. Trying to call it generates log spam.

Modernize the modified file with base::MakeUnique while we are here.

BUG=695383
==========

to

==========
Do not call GetDisplayDevice for older UPower versions.

On Linux, older versions of UPower did not have the GetDisplayDevice
method. Trying to call it generates log spam.

Modernize the modified file with base::MakeUnique while we are here.

BUG=695383

Review-Url: https://codereview.chromium.org/2795713003
Cr-Commit-Position: refs/heads/master@{#463358}
Committed:
https://chromium.googlesource.com/chromium/src/+/91037c1a4a82985c652ac38826fd...
==========

[commit-bot: I haz the power, 2017-04-10 19:25:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/91037c1a4a82985c652ac38826fd...