Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2795693004: Image Capture: add |points_of_interest| to mojo and wire it to IDL layer (Closed)

Created:
3 years, 8 months ago by mcasas
Modified:
3 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, chfremer+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, mcasas+imagecapture_chromium.org, blink-reviews, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Image Capture: add |points_of_interest| to mojo and wire it to IDL layer This CL adds an array<Point2D> |points_of_interest| member to image_capture.mojom and wires the use of the equivalent members from idl, i.e. points of interest are: - cached (as a constraint) when being set via applyConstraints(), and produced upon getConstraints(); - cached (as status) when being read back from the mojo pipe, together with other Capabilities, and produced upon request on getSettings(). LayoutTests updated. The only platform supporting points of interest currently is Android -- will be updated in a subsequent CL. BUG=700607 Review-Url: https://codereview.chromium.org/2795693004 Cr-Commit-Position: refs/heads/master@{#461629} Committed: https://chromium.googlesource.com/chromium/src/+/6f7ac2ab3f093655cddec3e000578e625dcd6c31

Patch Set 1 : #

Total comments: 2

Patch Set 2 : reillyg@ comments: Added a MediaSettingsRange::create() to avoid Clone() #

Total comments: 2

Patch Set 3 : reillyg@ comment #

Total comments: 1

Messages

Total messages: 21 (12 generated)
mcasas
reillyg@ ptal (easy review) tsepez@ RS plz mojom micro-addition.
3 years, 8 months ago (2017-04-03 23:51:59 UTC) #6
Tom Sepez
RS LGTM
3 years, 8 months ago (2017-04-04 00:05:09 UTC) #7
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2795693004/diff/40001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2795693004/diff/40001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp#newcode520 third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:520: mojo::Clone(capabilities.exposure_compensation))); Update MediaSettingsRange::create() to take a const media::mojom::blink::Range&?
3 years, 8 months ago (2017-04-04 00:06:06 UTC) #8
mcasas
ptal https://codereview.chromium.org/2795693004/diff/40001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2795693004/diff/40001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp#newcode520 third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:520: mojo::Clone(capabilities.exposure_compensation))); On 2017/04/04 00:06:06, Reilly Grant wrote: > ...
3 years, 8 months ago (2017-04-04 00:30:43 UTC) #9
Reilly Grant (use Gerrit)
lgtm https://codereview.chromium.org/2795693004/diff/60001/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h File third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h (right): https://codereview.chromium.org/2795693004/diff/60001/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h#newcode25 third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h:25: return MediaSettingsRange::create(range->max, range->min, range->current, return MediaSettingsRange::create(*range); (The .get() ...
3 years, 8 months ago (2017-04-04 00:48:45 UTC) #10
mcasas
https://codereview.chromium.org/2795693004/diff/60001/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h File third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h (right): https://codereview.chromium.org/2795693004/diff/60001/third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h#newcode25 third_party/WebKit/Source/modules/imagecapture/MediaSettingsRange.h:25: return MediaSettingsRange::create(range->max, range->min, range->current, On 2017/04/04 00:48:45, Reilly Grant ...
3 years, 8 months ago (2017-04-04 01:42:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795693004/80001
3 years, 8 months ago (2017-04-04 02:09:48 UTC) #17
Reilly Grant (use Gerrit)
https://codereview.chromium.org/2795693004/diff/80001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp File third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp (right): https://codereview.chromium.org/2795693004/diff/80001/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp#newcode520 third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp:520: MediaSettingsRange::create(*capabilities.exposure_compensation.get())); .get() can be removed here as well.
3 years, 8 months ago (2017-04-04 03:59:37 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 04:27:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6f7ac2ab3f093655cddec3e00057...

Powered by Google App Engine
This is Rietveld 408576698