Change VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner

Change VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner

Currently, VideoFrameReceiverOnIOThread uses hard coded content::
BrowserThread::PostTask(content::BrowserThread::IO, ... to post tasks.
This CL removes such hard coding to make VideoFrameReceiverOnIOThread
more generic by allowing it to post tasks to a SingleThreadTaskRunner.

BUG=674190
Review-Url: https://codereview.chromium.org/2795663002
Cr-Commit-Position: refs/heads/master@{#462186}
Committed: https://chromium.googlesource.com/chromium/src/+/d30d9afc9288d064df6fd9f12543ce5df8f351b5

[Chandan, 2017-04-03 08:39:54]

Description was changed from

==========
Change VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner

Currently, VideoFrameReceiverOnIOThread uses hard coded content::
BrowserThread::PostTask(content::BrowserThread::IO, ... to post tasks.
This CL removes such hard coding to make VideoFrameReceiverOnIOThread
more generic by allowing it to post tasks to a SingleThreadTaskRunner.

BUG=674190
==========

to

==========
Change VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner

Currently, VideoFrameReceiverOnIOThread uses hard coded content::
BrowserThread::PostTask(content::BrowserThread::IO, ... to post tasks.
This CL removes such hard coding to make VideoFrameReceiverOnIOThread
more generic by allowing it to post tasks to a SingleThreadTaskRunner.

BUG=674190
==========

[Chandan, 2017-04-03 08:39:55]

c.padhi@samsung.com changed reviewers:
+ a.suchit@chromium.org, chfremer@chromium.org, mcasas@chromium.org

[Chandan, 2017-04-03 08:40:17]

PTAL. Thank you.

[chfremer, 2017-04-03 16:27:02]

lgtm (with one nit)

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
File media/capture/video/video_frame_receiver_on_task_runner.h (right):

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:14: // specified
thread.
nit: We can make this more concrete by saying "... incoming calls to the given
|task_runner|."

[mcasas, 2017-04-03 17:14:24]

Can you plz upload after the changes with a 
lower similarity level? I.e.

git cl upload --similarity=25

so Rietveld will produce (more) coherent diffs? Thx.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
File media/capture/video/video_frame_receiver_on_task_runner.cc (right):

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.cc:1: // Copyright 2016
The Chromium Authors. All rights reserved.
s/2016/2017/

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
File media/capture/video/video_frame_receiver_on_task_runner.h (right):

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:1: // Copyright 2016
The Chromium Authors. All rights reserved.
s/2016/2017/

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:8: #include
"base/single_thread_task_runner.h"
Forward declare SingleThreadTaskRunner:

namespace base {
class SingleThreadTaskRunner;
}  // namespace base

and move the include to the .cc file.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:40:
base::WeakPtr<VideoFrameReceiver> receiver_;
Can be made const?

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:41:
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
const.

[Chandan, 2017-04-04 07:27:09]

Uploaded patchset 2 with similarity level 25. PTAL. Thank you.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
File media/capture/video/video_frame_receiver_on_task_runner.cc (right):

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.cc:1: // Copyright 2016
The Chromium Authors. All rights reserved.
On 2017/04/03 17:14:23, mcasas wrote:
> s/2016/2017/

Done.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
File media/capture/video/video_frame_receiver_on_task_runner.h (right):

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:1: // Copyright 2016
The Chromium Authors. All rights reserved.
On 2017/04/03 17:14:23, mcasas wrote:
> s/2016/2017/

Done.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:8: #include
"base/single_thread_task_runner.h"
On 2017/04/03 17:14:23, mcasas wrote:
> Forward declare SingleThreadTaskRunner:
> 
> namespace base {
> class SingleThreadTaskRunner;
> }  // namespace base
> 
> and move the include to the .cc file.

Done.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:14: // specified
thread.
On 2017/04/03 16:27:02, chfremer wrote:
> nit: We can make this more concrete by saying "... incoming calls to the given
> |task_runner|." 

Done.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:40:
base::WeakPtr<VideoFrameReceiver> receiver_;
On 2017/04/03 17:14:24, mcasas wrote:
> Can be made const?

Done.

https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
media/capture/video/video_frame_receiver_on_task_runner.h:41:
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
On 2017/04/03 17:14:24, mcasas wrote:
> const.

Done.

[mcasas, 2017-04-04 16:20:34]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 16:21:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-04-04 16:21:28]

On 2017/04/04 07:27:09, Chandan wrote:
> Uploaded patchset 2 with similarity level 25. PTAL. Thank you.
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> File media/capture/video/video_frame_receiver_on_task_runner.cc (right):
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> media/capture/video/video_frame_receiver_on_task_runner.cc:1: // Copyright
2016
> The Chromium Authors. All rights reserved.
> On 2017/04/03 17:14:23, mcasas wrote:
> > s/2016/2017/
> 
> Done.
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> File media/capture/video/video_frame_receiver_on_task_runner.h (right):
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> media/capture/video/video_frame_receiver_on_task_runner.h:1: // Copyright 2016
> The Chromium Authors. All rights reserved.
> On 2017/04/03 17:14:23, mcasas wrote:
> > s/2016/2017/
> 
> Done.
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> media/capture/video/video_frame_receiver_on_task_runner.h:8: #include
> "base/single_thread_task_runner.h"
> On 2017/04/03 17:14:23, mcasas wrote:
> > Forward declare SingleThreadTaskRunner:
> > 
> > namespace base {
> > class SingleThreadTaskRunner;
> > }  // namespace base
> > 
> > and move the include to the .cc file.
> 
> Done.
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> media/capture/video/video_frame_receiver_on_task_runner.h:14: // specified
> thread.
> On 2017/04/03 16:27:02, chfremer wrote:
> > nit: We can make this more concrete by saying "... incoming calls to the
given
> > |task_runner|." 
> 
> Done.
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> media/capture/video/video_frame_receiver_on_task_runner.h:40:
> base::WeakPtr<VideoFrameReceiver> receiver_;
> On 2017/04/03 17:14:24, mcasas wrote:
> > Can be made const?
> 
> Done.
> 
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> media/capture/video/video_frame_receiver_on_task_runner.h:41:
> scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
> On 2017/04/03 17:14:24, mcasas wrote:
> > const.
> 
> Done.

lgtm if bots are happy, thanks!

[commit-bot: I haz the power, 2017-04-04 16:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 16:23:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Chandan, 2017-04-04 17:59:53]

On 2017/04/04 16:21:28, mcasas wrote:
> On 2017/04/04 07:27:09, Chandan wrote:
> > Uploaded patchset 2 with similarity level 25. PTAL. Thank you.
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > File media/capture/video/video_frame_receiver_on_task_runner.cc (right):
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > media/capture/video/video_frame_receiver_on_task_runner.cc:1: // Copyright
> 2016
> > The Chromium Authors. All rights reserved.
> > On 2017/04/03 17:14:23, mcasas wrote:
> > > s/2016/2017/
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > File media/capture/video/video_frame_receiver_on_task_runner.h (right):
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > media/capture/video/video_frame_receiver_on_task_runner.h:1: // Copyright
2016
> > The Chromium Authors. All rights reserved.
> > On 2017/04/03 17:14:23, mcasas wrote:
> > > s/2016/2017/
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > media/capture/video/video_frame_receiver_on_task_runner.h:8: #include
> > "base/single_thread_task_runner.h"
> > On 2017/04/03 17:14:23, mcasas wrote:
> > > Forward declare SingleThreadTaskRunner:
> > > 
> > > namespace base {
> > > class SingleThreadTaskRunner;
> > > }  // namespace base
> > > 
> > > and move the include to the .cc file.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > media/capture/video/video_frame_receiver_on_task_runner.h:14: // specified
> > thread.
> > On 2017/04/03 16:27:02, chfremer wrote:
> > > nit: We can make this more concrete by saying "... incoming calls to the
> given
> > > |task_runner|." 
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > media/capture/video/video_frame_receiver_on_task_runner.h:40:
> > base::WeakPtr<VideoFrameReceiver> receiver_;
> > On 2017/04/03 17:14:24, mcasas wrote:
> > > Can be made const?
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/2795663002/diff/1/media/capture/video/video_f...
> > media/capture/video/video_frame_receiver_on_task_runner.h:41:
> > scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
> > On 2017/04/03 17:14:24, mcasas wrote:
> > > const.
> > 
> > Done.
> 
> lgtm if bots are happy, thanks!

It seems like a rebase is required. I see recent changes in
video_capture_manager.cc.

[a.suchit2, 2017-04-05 10:25:03]

The CQ bit was checked by a.suchit@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 10:25:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 10:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 10:50:27]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Chandan, 2017-04-05 11:06:41]

Rebased. CreateDeviceClient() was moved to InProcessBuildableVideoCaptureDevice
from VideoCaptureManager by https://codereview.chromium.org/2738763002/. Changed
VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner in
InProcessBuildableVideoCaptureDevice.
Please review. Thank you.

[chfremer, 2017-04-05 17:03:10]

still lgtm

[Chandan, 2017-04-05 17:19:23]

c.padhi@samsung.com changed reviewers:
+ avi@chromium.org

[Chandan, 2017-04-05 17:19:24]

avi@, please review content/browser/BUILD.gn. Thank you.

[Avi (use Gerrit), 2017-04-05 19:23:16]

lgtm

content stamp

[Chandan, 2017-04-05 19:38:39]

The CQ bit was checked by c.padhi@samsung.com

[Chandan, 2017-04-05 19:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2795663002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-05 19:39:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 19:46:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491421119631240,
"parent_rev": "7e64a797f7b6b4fb54536bbbc4c809c4fc6da3e1", "commit_rev":
"d30d9afc9288d064df6fd9f12543ce5df8f351b5"}

[commit-bot: I haz the power, 2017-04-05 19:47:23]

Description was changed from

==========
Change VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner

Currently, VideoFrameReceiverOnIOThread uses hard coded content::
BrowserThread::PostTask(content::BrowserThread::IO, ... to post tasks.
This CL removes such hard coding to make VideoFrameReceiverOnIOThread
more generic by allowing it to post tasks to a SingleThreadTaskRunner.

BUG=674190
==========

to

==========
Change VideoFrameReceiverOnIOThread to VideoFrameReceiverOnTaskRunner

Currently, VideoFrameReceiverOnIOThread uses hard coded content::
BrowserThread::PostTask(content::BrowserThread::IO, ... to post tasks.
This CL removes such hard coding to make VideoFrameReceiverOnIOThread
more generic by allowing it to post tasks to a SingleThreadTaskRunner.

BUG=674190

Review-Url: https://codereview.chromium.org/2795663002
Cr-Commit-Position: refs/heads/master@{#462186}
Committed:
https://chromium.googlesource.com/chromium/src/+/d30d9afc9288d064df6fd9f12543...
==========

[commit-bot: I haz the power, 2017-04-05 19:47:25]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d30d9afc9288d064df6fd9f12543...