Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9291)

Unified Diff: chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml

Issue 2795653006: Add icon to the Data Saver main menu footer and update to spec (Closed)
Patch Set: cropped icons Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml
diff --git a/chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml b/chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml
new file mode 100644
index 0000000000000000000000000000000000000000..4687a13153a138d4a6d790329f4753b9575b8424
--- /dev/null
+++ b/chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml
@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
+ <item
+ android:id="@+id/main_menu_chart"
+ android:drawable="@drawable/data_reduction_main_menu_chart"
+ android:layout_gravity="bottom"
Ted C 2017/04/10 16:48:48 I "think" this would need to be android:gravity="b
megjablon 2017/04/10 18:00:42 See below
+ android:top="8dp" />
Ted C 2017/04/10 16:48:48 if you did android:bottom="0dp", would that work i
megjablon 2017/04/10 18:00:42 Setting bottom offset doesn't work. The layer-list
+ <item android:drawable="@drawable/data_reduction_main_menu_chart_base" />
+</layer-list>

Powered by Google App Engine
This is Rietveld 408576698