chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml - Issue 2795653006: Add icon to the Data Saver main menu footer and update to spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/data_reduction_main_menu_icon.xml

Issue 2795653006: Add icon to the Data Saver main menu footer and update to spec (Closed)

Patch Set: cropped icons Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/data_reduction_main_menu_chart_base.png ('k') | chrome/android/java/res/layout/data_reduction_main_menu_footer.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <layer-list xmlns:android="http://schemas.android.com/apk/res/android">

	7 <item

	8 android:id="@+id/main_menu_chart"

	9 android:drawable="@drawable/data_reduction_main_menu_chart"

	10 android:layout_gravity="bottom"
	Ted C 2017/04/10 16:48:48 I "think" this would need to be android:gravity="b I "think" this would need to be android:gravity="bottom", but I don't believe you need this. megjablon 2017/04/10 18:00:42 See below Show quoted text On 2017/04/10 16:48:48, Ted C wrote: > I "think" this would need to be android:gravity="bottom", but I don't believe > you need this. See below
	11 android:top="8dp" />
	Ted C 2017/04/10 16:48:48 if you did android:bottom="0dp", would that work i if you did android:bottom="0dp", would that work instead of giving a top offset? megjablon 2017/04/10 18:00:42 Setting bottom offset doesn't work. The layer-list Show quoted text On 2017/04/10 16:48:48, Ted C wrote: > if you did android:bottom="0dp", would that work instead of giving a top offset? Setting bottom offset doesn't work. The layer-list stretches the item to fill the space, so this still allows the graph to be drawn to the top. Just found this in the developer guide: "All drawable items are scaled to fit the size of the containing View, by default. Thus, placing your images in a layer list at different positions might increase the size of the View and some images scale as appropriate. To avoid scaling items in the list, use a <bitmap> element inside the <item> element to specify the drawable and define the gravity to something that does not scale, such as "center"." https://developer.android.com/guide/topics/resources/drawable-resource.html#L... So I moved it into a bitmap.
	12 <item android:drawable="@drawable/data_reduction_main_menu_chart_base" />

	13 </layer-list>

OLD	NEW