Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2795613002: Make global callbacks usable outside appengine. (Closed)

Created:
3 years, 8 months ago by dsansome
Modified:
3 years, 8 months ago
CC:
bpastene, chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Make global callbacks usable outside appengine. This moves the ResetGlobalCallbackMetrics call inside tsmon's Flush, and adds a InvokeGlobalCallbacksOnFlush that defaults to true but is set to false on appengine. BUG=706912 Review-Url: https://codereview.chromium.org/2795613002 Committed: https://github.com/luci/luci-go/commit/82564cfcaebd57e7d65bb40997a050538a9845b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M appengine/tsmon/middleware.go View 2 chunks +1 line, -1 line 0 comments Download
M common/tsmon/context.go View 7 chunks +22 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dsansome
3 years, 8 months ago (2017-04-03 03:07:43 UTC) #2
Sergey Berezin (google)
LGTM, thanks!
3 years, 8 months ago (2017-04-03 20:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795613002/1
3 years, 8 months ago (2017-04-03 23:31:05 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 23:48:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/82564cfcaebd57e7d65bb40997a050538a9845b8

Powered by Google App Engine
This is Rietveld 408576698