Add an update warning for downloading over mobile data

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
index 45c902cf43aeff32a82126b177c7964dfb22fbbc..81a30bf61b3a4919017190b9b4db976791cff01b 100644
--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
@@ -269,6 +269,13 @@ void AddAboutStrings(content::WebUIDataSource* html_source) {
     {"aboutChannelDialogBeta", IDS_SETTINGS_ABOUT_PAGE_DIALOG_CHANNEL_BETA},
     {"aboutChannelDialogDev", IDS_SETTINGS_ABOUT_PAGE_DIALOG_CHANNEL_DEV},
     {"aboutChannelDialogStable", IDS_SETTINGS_ABOUT_PAGE_DIALOG_CHANNEL_STABLE},
+
+    // About page, update warning dialog.
+    {"aboutUpdateWarningMessage",
+     IDS_SETTINGS_ABOUT_PAGE_UPDATE_WARNING_MESSAGE},
+    {"aboutUpdateWarningTitle", IDS_SETTINGS_ABOUT_PAGE_UPDATE_WARNING_TITLE},
+    {"aboutUpdateWarningContinue",
+     IDS_SETTINGS_ABOUT_PAGE_UPDATE_WARNING_CONTINUE_BUTTON},
 #endif

[Lei Zhang, 2017/04/10 17:58:24]

BTW, this #ifdef section is getting long, and a // defined(OS_CHROMEOS) would be
helpful.

[weidongg, 2017/04/10 18:17:01]

Sorry, I don't understand. What do you mean by adding a // defined(OS_CHROMEOS)?

[Lei Zhang, 2017/04/10 18:28:33]

If one looks at
https://codereview.chromium.org/2795603002/diff/60001/chrome/browser/ui/webui...
with the default 10 lines of context, one has no idea what #if the #endif
corresponds to. Thus change it to:

#endif  // defined(OS_CHROMEOS)

to improve readability. Normally when an #ifdef section is really short, there
is no need. e.g.

#ifdef FOO
bar
#endif

but if bar becomes 50 lines long, then it would be better if the #endif has a
comment.

   };
   AddLocalizedStringsBulk(html_source, localized_strings,