Add an update warning for downloading over mobile data

chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/i18n/number_formatting.h"
@@ skipping 251 matching lines @@
      IDS_SETTINGS_ABOUT_PAGE_POWERWASH_WARNING_MESSAGE},
     {"aboutPowerwashWarningTitle",
      IDS_SETTINGS_ABOUT_PAGE_POWERWASH_WARNING_TITLE},
     {"aboutUnstableWarningMessage",
      IDS_SETTINGS_ABOUT_PAGE_UNSTABLE_WARNING_MESSAGE},
     {"aboutUnstableWarningTitle",
      IDS_SETTINGS_ABOUT_PAGE_UNSTABLE_WARNING_TITLE},
     {"aboutChannelDialogBeta", IDS_SETTINGS_ABOUT_PAGE_DIALOG_CHANNEL_BETA},
     {"aboutChannelDialogDev", IDS_SETTINGS_ABOUT_PAGE_DIALOG_CHANNEL_DEV},
     {"aboutChannelDialogStable", IDS_SETTINGS_ABOUT_PAGE_DIALOG_CHANNEL_STABLE},
+
+    // About page, update warning dialog.
+    {"aboutUpdateWarningMessage",
+     IDS_SETTINGS_ABOUT_PAGE_UPDATE_WARNING_MESSAGE},
+    {"aboutUpdateWarningTitle", IDS_SETTINGS_ABOUT_PAGE_UPDATE_WARNING_TITLE},
+    {"aboutUpdateWarningContinue",
+     IDS_SETTINGS_ABOUT_PAGE_UPDATE_WARNING_CONTINUE_BUTTON},
 #endif

[Lei Zhang, 2017/04/10 17:58:24]

BTW, this #ifdef section is getting long, and a // defined(OS_CHROMEOS) would be
helpful.

[weidongg, 2017/04/10 18:17:01]

Sorry, I don't understand. What do you mean by adding a // defined(OS_CHROMEOS)?

[Lei Zhang, 2017/04/10 18:28:33]

If one looks at
https://codereview.chromium.org/2795603002/diff/60001/chrome/browser/ui/webui...
with the default 10 lines of context, one has no idea what #if the #endif
corresponds to. Thus change it to:

#endif  // defined(OS_CHROMEOS)

to improve readability. Normally when an #ifdef section is really short, there
is no need. e.g.

#ifdef FOO
bar
#endif

but if bar becomes 50 lines long, then it would be better if the #endif has a
comment.

   };
   AddLocalizedStringsBulk(html_source, localized_strings,
                           arraysize(localized_strings));
 
   html_source->AddString(
       "aboutUpgradeUpToDate",
 #if defined(OS_CHROMEOS)
       ash::SubstituteChromeOSDeviceType(IDS_SETTINGS_UPGRADE_UP_TO_DATE));
 #else
       l10n_util::GetStringUTF16(IDS_SETTINGS_UPGRADE_UP_TO_DATE));
@@ skipping 1742 matching lines @@
 
 #if defined(OS_CHROMEOS)
   chromeos::network_element::AddLocalizedStrings(html_source);
 #endif
   policy_indicator::AddLocalizedStrings(html_source);
 
   html_source->SetJsonPath(kLocalizedStringsFile);
 }
 
 }  // namespace settings