Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp |
| diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp |
| index 1858130f979d45b9560496c44f1e500c446acfeb..394c2e9ccb145e4b8e476f65c93d820fd3251b7d 100644 |
| --- a/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp |
| +++ b/third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp |
| @@ -34,7 +34,6 @@ |
| #include "bindings/core/v8/ScriptState.h" |
| #include "bindings/core/v8/V8Binding.h" |
| #include "bindings/core/v8/V8ObjectConstructor.h" |
| -#include "core/dom/Modulator.h" |
| #include "platform/InstanceCounters.h" |
| #include "wtf/PtrUtil.h" |
| #include "wtf/StringExtras.h" |
| @@ -73,6 +72,7 @@ V8PerContextData::~V8PerContextData() { |
| if (isMainThread()) |
| InstanceCounters::decrementCounter( |
| InstanceCounters::V8PerContextDataCounter); |
| + m_dataMap.clear(); |
|
haraken
2017/04/05 02:08:09
Is this needed?
jbroman
2017/04/05 21:07:00
+1; the destructor should suffice
adithyas
2017/04/05 21:45:35
Ok, removed.
|
| } |
| std::unique_ptr<V8PerContextData> V8PerContextData::create( |
| @@ -189,14 +189,16 @@ void V8PerContextData::addCustomElementBinding( |
| m_customElementBindings.push_back(std::move(binding)); |
| } |
| -void V8PerContextData::setModulator(Modulator* modulator) { |
| - DCHECK(!m_modulator); |
| - DCHECK(modulator); |
| - m_modulator = modulator; |
| +void V8PerContextData::addData(const char* key, Data* data) { |
| + m_dataMap.set(key, data); |
| } |
| -void V8PerContextData::clearModulator() { |
| - m_modulator = nullptr; |
| +void V8PerContextData::clearData(const char* key) { |
| + m_dataMap.erase(key); |
| +} |
| + |
| +V8PerContextData::Data* V8PerContextData::getData(const char* key) { |
| + return m_dataMap.at(key); |
| } |
| } // namespace blink |