Abstract out Modulator from V8PerContextData

third_party/WebKit/Source/bindings/core/v8/V8PerContextData.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/V8PerContextData.h"
 
 #include "bindings/core/v8/ConditionalFeatures.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8ObjectConstructor.h"
-#include "core/dom/Modulator.h"
 #include "platform/InstanceCounters.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/StringExtras.h"
 #include <memory>
 #include <stdlib.h>
 
 namespace blink {
 
 V8PerContextData::V8PerContextData(v8::Local<v8::Context> context)
     : m_isolate(context->GetIsolate()),
@@ skipping 18 matching lines @@
 
   if (isMainThread())
     InstanceCounters::incrementCounter(
         InstanceCounters::V8PerContextDataCounter);
 }
 
 V8PerContextData::~V8PerContextData() {
   if (isMainThread())
     InstanceCounters::decrementCounter(
         InstanceCounters::V8PerContextDataCounter);
+  m_dataMap.clear();

[haraken, 2017/04/05 02:08:09]

Is this needed?

[jbroman, 2017/04/05 21:07:00]

+1; the destructor should suffice

[adithyas, 2017/04/05 21:45:35]

Ok, removed.

 }
 
 std::unique_ptr<V8PerContextData> V8PerContextData::create(
     v8::Local<v8::Context> context) {
   return WTF::wrapUnique(new V8PerContextData(context));
 }
 
 V8PerContextData* V8PerContextData::from(v8::Local<v8::Context> context) {
   return ScriptState::from(context)->perContextData();
 }
@@ skipping 96 matching lines @@
   *prototypeObject = prototypeForType(type);
   DCHECK(!prototypeObject->IsEmpty());
   return true;
 }
 
 void V8PerContextData::addCustomElementBinding(
     std::unique_ptr<V0CustomElementBinding> binding) {
   m_customElementBindings.push_back(std::move(binding));
 }
 
-void V8PerContextData::setModulator(Modulator* modulator) {
-  DCHECK(!m_modulator);
-  DCHECK(modulator);
-  m_modulator = modulator;
+void V8PerContextData::addData(const char* key, Data* data) {
+  m_dataMap.set(key, data);
 }
 
-void V8PerContextData::clearModulator() {
-  m_modulator = nullptr;
+void V8PerContextData::clearData(const char* key) {
+  m_dataMap.erase(key);
+}
+
+V8PerContextData::Data* V8PerContextData::getData(const char* key) {
+  return m_dataMap.at(key);
 }
 
 }  // namespace blink