Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2795393002: Make JSONArray::at() a const member function. (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
iclelland
CC:
chromium-reviews, blink-reviews, kinuko+watch, dproctor
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make JSONArray::at() a const member function. BUG= Review-Url: https://codereview.chromium.org/2795393002 Cr-Commit-Position: refs/heads/master@{#462100} Committed: https://chromium.googlesource.com/chromium/src/+/f72b235e0d5e1478276b00bcfa8ab8af1d5637e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/json/JSONValues.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/json/JSONValues.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
wychen
PTAL
3 years, 8 months ago (2017-04-04 23:06:55 UTC) #4
iclelland
lgtm
3 years, 8 months ago (2017-04-05 14:45:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795393002/1
3 years, 8 months ago (2017-04-05 16:09:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f72b235e0d5e1478276b00bcfa8ab8af1d5637e5
3 years, 8 months ago (2017-04-05 16:21:44 UTC) #12
wychen
3 years, 8 months ago (2017-04-05 18:51:16 UTC) #13
Message was sent while issue was closed.
This is used in https://codereview.chromium.org/2793103002/.

Powered by Google App Engine
This is Rietveld 408576698