Chromium Code Reviews

Issue 2795253002: [perf-prof][arm64] Emit unwinding info to record the saved FP (Closed)

Created:
3 years, 8 months ago by Pierre Langlois
Modified:
3 years, 8 months ago
Reviewers:
Jarin, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[perf-prof][arm64] Emit unwinding info to record the saved FP When emitting a frame, we always push the old frame pointer at offset 0 relative to the new frame pointer. However, we didn't emit DWARF opcodes to inform perf of this. BUG= Review-Url: https://codereview.chromium.org/2795253002 Cr-Commit-Position: refs/heads/master@{#44384} Committed: https://chromium.googlesource.com/v8/v8/+/2db1f598c56fb6e43c5c6f02062bc6793843a34f

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -0 lines)
M src/compiler/arm64/unwinding-info-writer-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments

Messages

Total messages: 8 (4 generated)
Pierre Langlois
3 years, 8 months ago (2017-04-04 14:48:04 UTC) #2
Jarin
lgtm. Thanks!
3 years, 8 months ago (2017-04-04 14:59:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795253002/1
3 years, 8 months ago (2017-04-04 15:00:20 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 15:37:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2db1f598c56fb6e43c5c6f02062bc679384...

Powered by Google App Engine