Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2795233002: Enable ConditionalCacheDeletionHelperBrowserTest.TimeAndURL again (Closed)

Created:
3 years, 8 months ago by dullweber
Modified:
3 years, 8 months ago
Reviewers:
msramek
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ConditionalCacheDeletionHelperBrowserTest.TimeAndURL again Change ConditionalCacheDeletionHelperBrowserTest.TimeAndURL to use TestTimeouts::tiny_timeout instead of a smaller custom timeout and enable it again on platforms that were previously flaky. BUG=624836, 646119 Review-Url: https://codereview.chromium.org/2795233002 Cr-Commit-Position: refs/heads/master@{#462014} Committed: https://chromium.googlesource.com/chromium/src/+/f48da6f6814d77b35c3d91a4df5dca714e01af0d

Patch Set 1 #

Patch Set 2 : remove reference to timeout_ms from comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
dullweber
Hi Martin, please review this cl. One round of trybots ran successfully and I manually ...
3 years, 8 months ago (2017-04-04 14:49:57 UTC) #4
msramek
Thanks! At least one of the ASANs is green now. LGTM
3 years, 8 months ago (2017-04-04 14:56:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795233002/20001
3 years, 8 months ago (2017-04-05 08:22:00 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 09:10:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f48da6f6814d77b35c3d91a4df5d...

Powered by Google App Engine
This is Rietveld 408576698