Issue 2795183003: Adding logic to prevent offline previews fallback to LoFi/Weblite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2795183003: Adding logic to prevent offline previews fallback to LoFi/Weblite (Closed)

Created:
3 years, 8 months ago by RyanSturm

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Adding logic to prevent offline previews fallback to LoFi/Weblite This adds ReloadType::DISABLE_LOFI_MODE to opt outs from offline previews to prevent reloads from offline previews causing a server preview from being shown. BUG=707060 Review-Url: https://codereview.chromium.org/2792443002 Cr-Commit-Position: refs/heads/master@{#461818} (cherry picked from commit 0340eb999c53a854636325ece62d211b661f67d1) Review-Url: https://codereview.chromium.org/2795183003 . Cr-Commit-Position: refs/branch-heads/3029@{#584} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/556ea0e0bea0983ae0130f1bb7bc0533b74d8590

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -8 lines)			Patch
	M	chrome/browser/previews/previews_infobar_delegate.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	chrome/browser/previews/previews_infobar_delegate_unittest.cc	View		8 chunks	+81 lines, -7 lines	0 comments	Download

Total messages: 2 (1 generated)

RyanSturm

3 years, 8 months ago (2017-04-04 22:56:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
556ea0e0bea0983ae0130f1bb7bc0533b74d8590.