Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html

Issue 2795173002: Do not show image placeholders for CSS sprites (Closed)
Patch Set: Addressed kouhei comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html b/third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html
new file mode 100644
index 0000000000000000000000000000000000000000..cf7e250a6e63ab5b6f97e1f742b5c6e49ace65a3
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html
@@ -0,0 +1,25 @@
+<!DOCTYPE html>
kouhei (in TOK) 2017/04/28 03:50:50 Please modify this test so that it will fit in exp
Raj 2017/04/28 18:01:21 Done.
+<body>
+ <!-- This test verifies if placeholder image is shown, instead of the original image. -->
+ <div id="placeholder"></div>
+ <br/>
+ <div id="placeholder_content_image_data"></div>
+ <br/>
+ <div id="placeholder_webkit_box_reflect"></div>
+ <script>
+ //window.internals.settings.setFetchImagePlaceholders(true);
kouhei (in TOK) 2017/04/28 03:50:50 this needs to be un-comment out?
Raj 2017/04/28 18:01:21 Yes. That was a mistake.
+ document.getElementById("placeholder").innerHTML = '<img src="https://127.0.0.1:8443/resources/square200.png">'
+
+ document.getElementById("placeholder_webkit_box_reflect").innerHTML =
+ '<img src="https://127.0.0.1:8443/resources/square200.png" style="-webkit-box-reflect: below">'
+
+ document.getElementById("placeholder_content_image_data").innerHTML =
+ '<div class="class_content_image_data"></div> \
+ <style> \
+ .class_content_image_data::before { \
+ content: url("https://127.0.0.1:8443/resources/square200.png"); \
+ } \
+ </style>'
+ </script>
+</body>
+

Powered by Google App Engine
This is Rietveld 408576698