third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html - Issue 2795173002: Do not show image placeholders for CSS sprites

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/previews/client-lofi.html

Issue 2795173002: Do not show image placeholders for CSS sprites (Closed)

Patch Set: Addressed kouhei comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/previews/client-lofi-expected.png » ('j') | third_party/WebKit/Source/core/css/CSSImageSetValue.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	kouhei (in TOK) 2017/04/28 03:50:50 Please modify this test so that it will fit in exp Please modify this test so that it will fit in expected.png w/o scrollbars. Raj 2017/04/28 18:01:21 Done. Show quoted text On 2017/04/28 03:50:50, kouhei wrote: > Please modify this test so that it will fit in expected.png w/o scrollbars. Done.
	2 <body>

	3 <!-- This test verifies if placeholder image is shown, instead of the original image. -->

	4 <div id="placeholder"></div>

	5 <br/>

	6 <div id="placeholder_content_image_data"></div>

	7 <br/>

	8 <div id="placeholder_webkit_box_reflect"></div>

	9 <script>

	10 //window.internals.settings.setFetchImagePlaceholders(true);
	kouhei (in TOK) 2017/04/28 03:50:50 this needs to be un-comment out? this needs to be un-comment out? Raj 2017/04/28 18:01:21 Yes. That was a mistake. Show quoted text On 2017/04/28 03:50:50, kouhei wrote: > this needs to be un-comment out? Yes. That was a mistake.
	11 document.getElementById("placeholder").innerHTML = '<img src="https://127.0. 0.1:8443/resources/square200.png">'

	12

	13 document.getElementById("placeholder_webkit_box_reflect").innerHTML =

	14 '<img src="https://127.0.0.1:8443/resources/square200.png" style="-webki t-box-reflect: below">'

	15

	16 document.getElementById("placeholder_content_image_data").innerHTML =

	17 '<div class="class_content_image_data"></div> \

	18 <style> \

	19 .class_content_image_data::before { \

	20 content: url("https://127.0.0.1:8443/resources/square200.png"); \

	21 } \

	22 </style>'

	23 </script>

	24 </body>

	25

OLD	NEW