Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 2795143003: MIPS[64]: Support for some SIMD operations (5) (Closed)

Created:
3 years, 8 months ago by dusan.simicic
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Support for some SIMD operations (5) Add support for I32x4Neg, I32x4LtS, I32x4LeS, I32x4LtU, I32x4LeU, I16x8Splat, I16x8ExtractLane, I16x8ReplaceLane, I16x8Neg, I16x8Shl, I16x8ShrS, I16x8ShrU, I16x8Add, I16x8AddSaturateS, I16x8Sub, I16x8SubSaturateS for mips32 and mips64 architectures. BUG= Review-Url: https://codereview.chromium.org/2795143003 Cr-Commit-Position: refs/heads/master@{#45092} Committed: https://chromium.googlesource.com/v8/v8/+/0fad007a98d7d20991c36f2328d56803706b3cad

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Rebasing #

Patch Set 4 : Rebasing #

Patch Set 5 : Add missing SIMD_LOWERING_TARGET #

Patch Set 6 : Fix x64 build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -35 lines) Patch
M src/compiler/instruction-selector.cc View 1 2 3 4 5 5 chunks +35 lines, -25 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 2 1 chunk +17 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 2 1 chunk +17 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 1 2 3 4 5 12 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
dusan.simicic
PTAL
3 years, 8 months ago (2017-04-04 08:42:31 UTC) #2
bbudge
lgtm
3 years, 8 months ago (2017-04-04 13:07:58 UTC) #3
dusan.simicic
PTAL + bmeurer, +jarin
3 years, 8 months ago (2017-04-19 12:47:58 UTC) #5
Benedikt Meurer
LGTM
3 years, 8 months ago (2017-04-19 13:05:05 UTC) #6
dusan.simicic
PS3: Rebased again + remainder for Ivica
3 years, 7 months ago (2017-04-27 13:05:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795143003/100001
3 years, 7 months ago (2017-05-04 12:31:55 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/v8/v8/+/0fad007a98d7d20991c36f2328d56803706b3cad
3 years, 7 months ago (2017-05-04 12:38:25 UTC) #25
Leszek Swirski
On 2017/05/04 12:38:25, commit-bot: I haz the power wrote: > Committed patchset #6 (id:100001) as ...
3 years, 6 months ago (2017-06-05 13:36:08 UTC) #26
ivica.bogosavljevic
3 years, 6 months ago (2017-06-05 13:55:59 UTC) #27
Message was sent while issue was closed.
On 2017/06/05 13:36:08, Leszek Swirski wrote:
> On 2017/05/04 12:38:25, commit-bot: I haz the power wrote:
> > Committed patchset #6 (id:100001) as
> >
>
https://chromium.googlesource.com/v8/v8/+/0fad007a98d7d20991c36f2328d56803706...
> 
> Our mips tests (running on a simulator) are broken as of this CL. Presumably
> this is a simulator vs. hardware difference, could you please check and update
> the simulator as necessary?

Simulator MIPS doesn't support yet SIMD extensions, we are still adding support.
In the meantime we are skipping SIMD tests on all buildbots since SIMD until
SIMD
lowering bugs get fixed. 

https://chromium-review.googlesource.com/c/524082

Powered by Google App Engine
This is Rietveld 408576698