Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2795123002: Fix Hindi language print preview cutoff (Closed)

Created:
3 years, 8 months ago by rbpotter
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Hindi language print preview cutoff Remove the line height parameter in the hint CSS so that the text is no longer cutoff in Hindi. The hint shows if there is an invalid value in pages (or scaling or copies). BUG=616372 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2795123002 Cr-Commit-Position: refs/heads/master@{#461825} Committed: https://chromium.googlesource.com/chromium/src/+/edde5cf5f6805ca0396c763aa4a6ba807c804153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/resources/print_preview/print_preview.css View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (10 generated)
dpapad
lgtm
3 years, 8 months ago (2017-04-04 17:03:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795123002/1
3 years, 8 months ago (2017-04-04 19:03:27 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 20:47:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/edde5cf5f6805ca0396c763aa4a6...

Powered by Google App Engine
This is Rietveld 408576698