 Chromium Code Reviews
 Chromium Code Reviews Issue 2795113002:
  Move ownership of TextCheckerClientImpl to WebLocalFrameImpl  (Closed)
    
  
    Issue 2795113002:
  Move ownership of TextCheckerClientImpl to WebLocalFrameImpl  (Closed) 
  | Index: third_party/WebKit/Source/web/TextCheckerClientImpl.h | 
| diff --git a/third_party/WebKit/Source/web/TextCheckerClientImpl.h b/third_party/WebKit/Source/web/TextCheckerClientImpl.h | 
| index e694a92eaa8214d17b90f90a43ed0cea5c6e7e1c..b2d6556c76cd217c1ffd9749e97f92edc47ed82d 100644 | 
| --- a/third_party/WebKit/Source/web/TextCheckerClientImpl.h | 
| +++ b/third_party/WebKit/Source/web/TextCheckerClientImpl.h | 
| @@ -5,17 +5,19 @@ | 
| #ifndef TextCheckerClientImpl_h | 
| #define TextCheckerClientImpl_h | 
| +#include "platform/heap/Handle.h" | 
| #include "platform/text/TextCheckerClient.h" | 
| namespace blink { | 
| -class WebViewImpl; | 
| +class WebLocalFrameImpl; | 
| +class WebTextCheckClient; | 
| -// TODO(xiaochengh): Move ownership of this class to WebLocalFrameImpl. | 
| -class TextCheckerClientImpl final : public TextCheckerClient { | 
| +class TextCheckerClientImpl final | 
| + : public GarbageCollected<TextCheckerClientImpl>, | 
| + public TextCheckerClient { | 
| public: | 
| - TextCheckerClientImpl(WebViewImpl*); | 
| - ~TextCheckerClientImpl() final; | 
| + TextCheckerClientImpl(WebLocalFrameImpl*); | 
| 
haraken
2017/04/04 05:19:22
Add explicit.
 
Xiaocheng
2017/04/04 19:28:56
Done.
 | 
| void checkSpellingOfString(const String&, | 
| int* misspellingLocation, | 
| @@ -23,8 +25,12 @@ class TextCheckerClientImpl final : public TextCheckerClient { | 
| void requestCheckingOfString(TextCheckingRequest*) final; | 
| void cancelAllPendingRequests() final; | 
| + DECLARE_TRACE(); | 
| + | 
| private: | 
| - WebViewImpl* m_webView; | 
| + WebTextCheckClient* webTextCheckClient() const; | 
| + | 
| + Member<WebLocalFrameImpl> m_webLocalFrame; | 
| }; | 
| } // namespace blink |