Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: third_party/WebKit/Source/web/TextCheckerClientImpl.h

Issue 2795113002: Move ownership of TextCheckerClientImpl to WebLocalFrameImpl (Closed)
Patch Set: Mon Apr 3 18:57:07 PDT 2017 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/TextCheckerClientImpl.h
diff --git a/third_party/WebKit/Source/web/TextCheckerClientImpl.h b/third_party/WebKit/Source/web/TextCheckerClientImpl.h
index e694a92eaa8214d17b90f90a43ed0cea5c6e7e1c..b2d6556c76cd217c1ffd9749e97f92edc47ed82d 100644
--- a/third_party/WebKit/Source/web/TextCheckerClientImpl.h
+++ b/third_party/WebKit/Source/web/TextCheckerClientImpl.h
@@ -5,17 +5,19 @@
#ifndef TextCheckerClientImpl_h
#define TextCheckerClientImpl_h
+#include "platform/heap/Handle.h"
#include "platform/text/TextCheckerClient.h"
namespace blink {
-class WebViewImpl;
+class WebLocalFrameImpl;
+class WebTextCheckClient;
-// TODO(xiaochengh): Move ownership of this class to WebLocalFrameImpl.
-class TextCheckerClientImpl final : public TextCheckerClient {
+class TextCheckerClientImpl final
+ : public GarbageCollected<TextCheckerClientImpl>,
+ public TextCheckerClient {
public:
- TextCheckerClientImpl(WebViewImpl*);
- ~TextCheckerClientImpl() final;
+ TextCheckerClientImpl(WebLocalFrameImpl*);
haraken 2017/04/04 05:19:22 Add explicit.
Xiaocheng 2017/04/04 19:28:56 Done.
void checkSpellingOfString(const String&,
int* misspellingLocation,
@@ -23,8 +25,12 @@ class TextCheckerClientImpl final : public TextCheckerClient {
void requestCheckingOfString(TextCheckingRequest*) final;
void cancelAllPendingRequests() final;
+ DECLARE_TRACE();
+
private:
- WebViewImpl* m_webView;
+ WebTextCheckClient* webTextCheckClient() const;
+
+ Member<WebLocalFrameImpl> m_webLocalFrame;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698