Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: third_party/WebKit/Source/web/TextCheckerClientImpl.h

Issue 2795113002: Move ownership of TextCheckerClientImpl to WebLocalFrameImpl (Closed)
Patch Set: Mon Apr 3 18:57:07 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TextCheckerClientImpl_h 5 #ifndef TextCheckerClientImpl_h
6 #define TextCheckerClientImpl_h 6 #define TextCheckerClientImpl_h
7 7
8 #include "platform/heap/Handle.h"
8 #include "platform/text/TextCheckerClient.h" 9 #include "platform/text/TextCheckerClient.h"
9 10
10 namespace blink { 11 namespace blink {
11 12
12 class WebViewImpl; 13 class WebLocalFrameImpl;
14 class WebTextCheckClient;
13 15
14 // TODO(xiaochengh): Move ownership of this class to WebLocalFrameImpl. 16 class TextCheckerClientImpl final
15 class TextCheckerClientImpl final : public TextCheckerClient { 17 : public GarbageCollected<TextCheckerClientImpl>,
18 public TextCheckerClient {
16 public: 19 public:
17 TextCheckerClientImpl(WebViewImpl*); 20 TextCheckerClientImpl(WebLocalFrameImpl*);
haraken 2017/04/04 05:19:22 Add explicit.
Xiaocheng 2017/04/04 19:28:56 Done.
18 ~TextCheckerClientImpl() final;
19 21
20 void checkSpellingOfString(const String&, 22 void checkSpellingOfString(const String&,
21 int* misspellingLocation, 23 int* misspellingLocation,
22 int* misspellingLength) final; 24 int* misspellingLength) final;
23 void requestCheckingOfString(TextCheckingRequest*) final; 25 void requestCheckingOfString(TextCheckingRequest*) final;
24 void cancelAllPendingRequests() final; 26 void cancelAllPendingRequests() final;
25 27
28 DECLARE_TRACE();
29
26 private: 30 private:
27 WebViewImpl* m_webView; 31 WebTextCheckClient* webTextCheckClient() const;
32
33 Member<WebLocalFrameImpl> m_webLocalFrame;
28 }; 34 };
29 35
30 } // namespace blink 36 } // namespace blink
31 37
32 #endif 38 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698