[inspector] introduced StackFrame::IsWasm flag

[inspector] introduced StackFrame::IsWasm flag

We don't need to do any kind of translation for non-wasm frames. And we need this knowledge for lazy symbolization.
Capturing stack trace is ~7% faster.

BUG=v8:6189
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2795103004
Cr-Commit-Position: refs/heads/master@{#44502}
Committed: https://chromium.googlesource.com/v8/v8/+/c0c1d760283a52918ac0cbf5237e010930ffb734

[kozy, 2017-04-05 00:23:12]

Dmitry and Yang, please take a look.

[Yang, 2017-04-05 06:56:51]

lgtm

[dgozman, 2017-04-05 15:35:05]

https://codereview.chromium.org/2795103004/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2795103004/diff/1/include/v8.h#newcode1651
include/v8.h:1651: * return whether or not the associated functions is defined
in wasm.
nit: all comments around are capitalized.

https://codereview.chromium.org/2795103004/diff/1/include/v8.h#newcode1653
include/v8.h:1653: bool IsWasm() const;
Not sure we have to expose this in v8.h just for inspector. We can as well use
private method in debug-interface. Yang, WDYT?

[kozy, 2017-04-05 15:43:41]

https://codereview.chromium.org/2795103004/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2795103004/diff/1/include/v8.h#newcode1653
include/v8.h:1653: bool IsWasm() const;
On 2017/04/05 15:35:05, dgozman wrote:
> Not sure we have to expose this in v8.h just for inspector. We can as well use
> private method in debug-interface. Yang, WDYT?

I'd like to expose it here otherwise user could not differentiate regular frames
and wasm frames and since they have different meaning of line number and column
number - it can be confusing.

[kozy, 2017-04-05 15:54:37]

comment fixed.

https://codereview.chromium.org/2795103004/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2795103004/diff/1/include/v8.h#newcode1651
include/v8.h:1651: * return whether or not the associated functions is defined
in wasm.
On 2017/04/05 15:35:05, dgozman wrote:
> nit: all comments around are capitalized.

Done.

[kozy, 2017-04-05 15:54:46]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 15:54:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 16:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 16:23:15]

Dry run: This issue passed the CQ dry run.

[dgozman, 2017-04-06 19:22:40]

lgtm

[kozy, 2017-04-08 22:00:10]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-04-08 22:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
yangguo@chromium.org, dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2795103004/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2017-04-08 22:00:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 22:26:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491688810405900,
"parent_rev": "d9691952c1825ca9c8f73db5f63f842da9226cd8", "commit_rev":
"c0c1d760283a52918ac0cbf5237e010930ffb734"}

[commit-bot: I haz the power, 2017-04-08 22:26:29]

Description was changed from

==========
[inspector] introduced StackFrame::IsWasm flag

We don't need to do any kind of translation for non-wasm frames. And we need
this knowledge for lazy symbolization.
Capturing stack trace is ~7% faster.

BUG=v8:6189
R=dgozman@chromium.org,yangguo@chromium.org
==========

to

==========
[inspector] introduced StackFrame::IsWasm flag

We don't need to do any kind of translation for non-wasm frames. And we need
this knowledge for lazy symbolization.
Capturing stack trace is ~7% faster.

BUG=v8:6189
R=dgozman@chromium.org,yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2795103004
Cr-Commit-Position: refs/heads/master@{#44502}
Committed:
https://chromium.googlesource.com/v8/v8/+/c0c1d760283a52918ac0cbf5237e010930f...
==========

[commit-bot: I haz the power, 2017-04-08 22:26:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/c0c1d760283a52918ac0cbf5237e010930f...

[Yang, 2017-04-08 22:45:13]

On 2017/04/08 22:26:30, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/v8/v8/+/c0c1d760283a52918ac0cbf5237e010930f...

Please make sure not to use the newly introduced API in Chrome, at least until
branch point!