Chromium Code Reviews Chromium Code Reviews
Issue
2795103003:
Revert of [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user … (Closed)
DescriptionRevert of [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user … (patchset #1 id:1 of https://codereview.chromium.org/2790073003/ )
Reason for revert:
CL breaks the M-58 build: https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R58-9334.B/builds/145/steps/BuildPackages/logs/stdio
Original issue's description:
> [Merge to M58] cros: Treat set rotation for chrome.system.display API in touchview mode as if user rotation lock
>
> Changes:
> Expose an API SetLockToOrientation for chrome.system.display set rotation that will do the work like user rotation lock.
>
> TBR=oshima@chromium.org, lazyboy@chromium.org
> BUG=704931
> TEST=test coverage
>
> Review-Url: https://codereview.chromium.org/2784043002
> Cr-Commit-Position: refs/heads/master@{#461559}
> (cherry picked from commit c5bd9a545c026646b4f9bc35aba650ff01c87edd)
>
> Review-Url: https://codereview.chromium.org/2790073003 .
> Cr-Commit-Position: refs/branch-heads/3029@{#558}
> Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae235144d5ef8313dfc90d70e3204b7625a60342
TBR=lazyboy@chromium.org,oshima@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704931
Review-Url: https://codereview.chromium.org/2795103003
Cr-Commit-Position: refs/branch-heads/3029@{#568}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
Committed: https://chromium.googlesource.com/chromium/src/+/9dbee700a85e03f3611607cd585eac218564c4ba
Patch Set 1 #
Messages
Total messages: 3 (2 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||
