[regexp] Disallow '\' in capture names

[regexp] Disallow '\' in capture names

IdentifierStart::Is and IdentifierContinue::Is both return true for '\'.
The reason for this is lost to history.

Special-case '\' in the regexp parser to handle this.

BUG=v8:5437, v8:5868
Review-Url: https://codereview.chromium.org/2795093003
Cr-Commit-Position: refs/heads/master@{#44396}
Committed: https://chromium.googlesource.com/v8/v8/+/d890ec3261b09aca90e50b8a814a737602b071cf

[jgruber, 2017-04-04 12:14:50]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 12:14:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-04 12:15:15]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[jgruber, 2017-04-04 12:20:12]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 12:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-04-04 12:21:25]

Description was changed from

==========
[regexp] Disallow '\' as first character of capture names

IdentifierStart::Is() returns true for '\'. The reason for this is lost
to history. Special-case '\' in the regexp parser to handle this.

BUG=v8:5437,v8:5868
==========

to

==========
[regexp] Disallow '\' in capture names

IdentifierStart::Is and IdentifierContinue::Is both return true for '\'.
The reason for this is lost to history.

Special-case '\' in the regexp parser to handle this.

BUG=v8:5437,v8:5868
==========

[commit-bot: I haz the power, 2017-04-04 12:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 12:42:48]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-04-05 06:50:59]

On 2017/04/04 12:15:16, jgruber wrote:

LGTM. I will have to figure out the reason for why "\" is included in
IdentifierStart::Is though.

[jgruber, 2017-04-05 07:00:10]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-04-05 07:00:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 07:01:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491375610752220,
"parent_rev": "026ce2853243839b4955eae40bf62c7c4526129a", "commit_rev":
"d890ec3261b09aca90e50b8a814a737602b071cf"}

[commit-bot: I haz the power, 2017-04-05 07:01:56]

Description was changed from

==========
[regexp] Disallow '\' in capture names

IdentifierStart::Is and IdentifierContinue::Is both return true for '\'.
The reason for this is lost to history.

Special-case '\' in the regexp parser to handle this.

BUG=v8:5437,v8:5868
==========

to

==========
[regexp] Disallow '\' in capture names

IdentifierStart::Is and IdentifierContinue::Is both return true for '\'.
The reason for this is lost to history.

Special-case '\' in the regexp parser to handle this.

BUG=v8:5437,v8:5868

Review-Url: https://codereview.chromium.org/2795093003
Cr-Commit-Position: refs/heads/master@{#44396}
Committed:
https://chromium.googlesource.com/v8/v8/+/d890ec3261b09aca90e50b8a814a737602b...
==========

[commit-bot: I haz the power, 2017-04-05 07:01:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d890ec3261b09aca90e50b8a814a737602b...