Treat responses with LoFi headers as being LoFi images.

Treat responses with LoFi headers as being LoFi images.

Before this CL, if a LoFi image was somehow loaded without the
SERVER_LOFI_ON previews state bit set on the respective request, Blink
would not reload that image if the user opts out of the LoFi experience
on that page.

This CL causes Blink to recognize any loaded image with the LoFi
response headers as a LoFi image, regardless of its previews state bits.

BUG=707916
Review-Url: https://codereview.chromium.org/2795073003
Cr-Commit-Position: refs/heads/master@{#462686}
Committed: https://chromium.googlesource.com/chromium/src/+/c80839644b4cb376602ec2e600229c49cece3509

[sclittle, 2017-04-03 23:39:11]

sclittle@chromium.org changed reviewers:
+ japhet@chromium.org, megjablon@chromium.org

[megjablon, 2017-04-04 00:52:07]

lgtm % comments

https://codereview.chromium.org/2795073003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
(right):

https://codereview.chromium.org/2795073003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:552:
ReloadIfLoFiOrPlaceholderAfterFinishedWithoutServerLoFiOnBit) {
Do we need this and the above test? Since the previews state doesn't matter
anyway, I feel like this test covers the above one and that one can be deleted.

https://codereview.chromium.org/2795073003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:698:
initialResourceResponse.addHTTPHeaderField("chrome-proxy", "q=low");
This is an old test, but I was checking our coverage and noticed this is the old
header and we don't check the header anyway. Maybe just send the response
without any Lo-Fi headers like in
ReloadIfLoFiOrPlaceholderAfterFinishedWithoutLoFiHeaders.

[sclittle, 2017-04-04 03:12:16]

https://codereview.chromium.org/2795073003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
(right):

https://codereview.chromium.org/2795073003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:552:
ReloadIfLoFiOrPlaceholderAfterFinishedWithoutServerLoFiOnBit) {
On 2017/04/04 00:52:06, megjablon wrote:
> Do we need this and the above test? Since the previews state doesn't matter
> anyway, I feel like this test covers the above one and that one can be
deleted.

Done.

https://codereview.chromium.org/2795073003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp:698:
initialResourceResponse.addHTTPHeaderField("chrome-proxy", "q=low");
On 2017/04/04 00:52:06, megjablon wrote:
> This is an old test, but I was checking our coverage and noticed this is the
old
> header and we don't check the header anyway. Maybe just send the response
> without any Lo-Fi headers like in
> ReloadIfLoFiOrPlaceholderAfterFinishedWithoutLoFiHeaders. 

Done.

[sclittle, 2017-04-06 18:37:46]

@japhet: Friendly ping! I want to get this fix in ASAP so that it can be merged
into M58, and that will be much harder after the big Blink rename that's going
to happen this week.

[Nate Chapin, 2017-04-06 22:01:40]

lgtm

[sclittle, 2017-04-06 22:02:27]

The CQ bit was checked by sclittle@chromium.org

[sclittle, 2017-04-06 22:02:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
megjablon@chromium.org
Link to the patchset: https://codereview.chromium.org/2795073003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-04-06 22:04:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 23:42:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491516147137850,
"parent_rev": "897d20df0777854e91b4afab0923e917cd06640a", "commit_rev":
"c80839644b4cb376602ec2e600229c49cece3509"}

[commit-bot: I haz the power, 2017-04-06 23:43:21]

Description was changed from

==========
Treat responses with LoFi headers as being LoFi images.

Before this CL, if a LoFi image was somehow loaded without the
SERVER_LOFI_ON previews state bit set on the respective request, Blink
would not reload that image if the user opts out of the LoFi experience
on that page.

This CL causes Blink to recognize any loaded image with the LoFi
response headers as a LoFi image, regardless of its previews state bits.

BUG=707916
==========

to

==========
Treat responses with LoFi headers as being LoFi images.

Before this CL, if a LoFi image was somehow loaded without the
SERVER_LOFI_ON previews state bit set on the respective request, Blink
would not reload that image if the user opts out of the LoFi experience
on that page.

This CL causes Blink to recognize any loaded image with the LoFi
response headers as a LoFi image, regardless of its previews state bits.

BUG=707916

Review-Url: https://codereview.chromium.org/2795073003
Cr-Commit-Position: refs/heads/master@{#462686}
Committed:
https://chromium.googlesource.com/chromium/src/+/c80839644b4cb376602ec2e60022...
==========

[commit-bot: I haz the power, 2017-04-06 23:43:23]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c80839644b4cb376602ec2e60022...