Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2795043003: Clean up printer preference handling. (Closed)

Created:
3 years, 8 months ago by skau
Modified:
3 years, 8 months ago
Reviewers:
xdai1
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up printer preference handling. Remove the unused printer preference functions and update logging for policy printers. BUG=707910, 692156 Review-Url: https://codereview.chromium.org/2795043003 Cr-Commit-Position: refs/heads/master@{#462218} Committed: https://chromium.googlesource.com/chromium/src/+/9b72274704e60dd63ac41cb0520ae8dfd7a13cb8

Patch Set 1 #

Patch Set 2 : log missing fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -142 lines) Patch
M chromeos/printing/printer_translator.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chromeos/printing/printer_translator.cc View 1 5 chunks +30 lines, -69 lines 0 comments Download
M chromeos/printing/printer_translator_unittest.cc View 1 3 chunks +60 lines, -64 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
skau
Please take a look. Everything should be covered by the unit test updates.
3 years, 8 months ago (2017-04-04 17:17:03 UTC) #4
xdai1
lgtm Please update the BUG field in your CL's description. (the associated two bugs are ...
3 years, 8 months ago (2017-04-05 20:26:05 UTC) #7
skau
Thanks!
3 years, 8 months ago (2017-04-05 20:29:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2795043003/20001
3 years, 8 months ago (2017-04-05 20:30:23 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 21:20:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b72274704e60dd63ac41cb0520a...

Powered by Google App Engine
This is Rietveld 408576698