Revert of SurfaceManager::CreateSurface must set the surface's factory

Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset #6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed: https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b8946604abe71

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2794993002
Cr-Commit-Position: refs/heads/master@{#461535}
Committed: https://chromium.googlesource.com/chromium/src/+/5ecb82217368349f41e3227f28cd238f26e04d50

[Saman Sami, 2017-04-03 17:37:26]

Created Revert of SurfaceManager::CreateSurface must set the surface's factory

[Saman Sami, 2017-04-03 17:37:43]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Saman Sami, 2017-04-03 17:37:53]

Description was changed from

==========
Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset
#6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b...

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
==========

to

==========
Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset
#6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b...

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
==========

[Saman Sami, 2017-04-03 17:37:53]

samans@chromium.org changed reviewers:
- fsamuel@chromium.org, jbauman@chromium.org

[commit-bot: I haz the power, 2017-04-03 17:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-03 18:55:18]

samans@chromium.org changed reviewers:
+ fsamuel@chromium.org, jbauman@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:04:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-04-03 19:04:32]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[Fady Samuel, 2017-04-03 19:05:42]

Yay, lgtm.

[commit-bot: I haz the power, 2017-04-03 19:05:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 19:13:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 19:13:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Saman Sami, 2017-04-03 19:38:52]

Description was changed from

==========
Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset
#6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b...

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
==========

to

==========
Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset
#6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b...

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-04-03 19:39:27]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 19:40:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-03 20:21:50]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-04-03 20:22:01]

The CQ bit was checked by samans@chromium.org

[Saman Sami, 2017-04-03 20:22:01]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/2794993002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-03 20:22:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-03 21:04:04]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491250921381370,
"parent_rev": "2b2e80acce1c253615137ccdd101e6c390458d23", "commit_rev":
"5ecb82217368349f41e3227f28cd238f26e04d50"}

[commit-bot: I haz the power, 2017-04-03 21:04:55]

Description was changed from

==========
Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset
#6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b...

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Revert of SurfaceManager::CreateSurface must set the surface's factory (patchset
#6 id:120001 of https://codereview.chromium.org/2760433002/ )

Reason for revert:
Should not be necessary anymore now that crbug.com/701988 is fixed.

Original issue's description:
> SurfaceManager::CreateSurface must set the surface's factory
> 
> This change is necessary because DelegatedFrameHost can be destroyed
> and recreated when RendererCompositorFrameSink is alive the whole time
> and can potentially send the same LocalSurfaceId to both instances of 
> DelegatedFrameHost.
> 
> BUG=697864
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
> 
> Review-Url: https://codereview.chromium.org/2760433002
> Cr-Commit-Position: refs/heads/master@{#458138}
> Committed:
https://chromium.googlesource.com/chromium/src/+/9e0fd9a87d69362103af512b8e7b...

TBR=fsamuel@chromium.org,jbauman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=697864
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2794993002
Cr-Commit-Position: refs/heads/master@{#461535}
Committed:
https://chromium.googlesource.com/chromium/src/+/5ecb82217368349f41e3227f28cd...
==========

[commit-bot: I haz the power, 2017-04-03 21:04:56]

Committed patchset #2 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/5ecb82217368349f41e3227f28cd...