Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2794893003: Fix visual studio project files around SK_FREETYPE_MINIMUM_RUNTIME_VERSION (Closed)

Created:
3 years, 8 months ago by michaeln
Modified:
3 years, 8 months ago
Reviewers:
drott, brettw
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix visual studio project files around SK_FREETYPE_MINIMUM_RUNTIME_VERSION Replaced use of bit shifting operators with multiplication because visual studio fails to open projects using the '<<' operator in preprocessor definitions. BUG=700926 Review-Url: https://codereview.chromium.org/2794893003 Cr-Commit-Position: refs/heads/master@{#461572} Committed: https://chromium.googlesource.com/chromium/src/+/32fda6433bcc281eb4794b8715cf44edb3dd1ce2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M skia/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
michaeln
ptal... i see there's another potential fix for this, if you prefer the other fix, ...
3 years, 8 months ago (2017-04-03 21:32:45 UTC) #3
brettw
lgtm
3 years, 8 months ago (2017-04-03 21:45:30 UTC) #7
michaeln
On 2017/04/03 21:45:30, brettw (plz ping after 24h) wrote: > lgtm k, thnx, i'll cq ...
3 years, 8 months ago (2017-04-03 21:52:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794893003/1
3 years, 8 months ago (2017-04-03 21:57:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/32fda6433bcc281eb4794b8715cf44edb3dd1ce2
3 years, 8 months ago (2017-04-03 23:06:45 UTC) #14
drott
3 years, 8 months ago (2017-04-04 07:11:16 UTC) #15
Message was sent while issue was closed.
non owner lgtm, thanks for taking care of this!

Powered by Google App Engine
This is Rietveld 408576698