Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1304)

Issue 2794893002: Remove myself from some geolocation owners files and watchlist. (Closed)

Created:
3 years, 1 month ago by Michael van Ouwerkerk
Modified:
3 years, 1 month ago
Reviewers:
Ted C, timvolodine
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-geolocation_chromium.org, mcasas+geolocation_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove myself from some geolocation owners files and watchlist. Review-Url: https://codereview.chromium.org/2794893002 Cr-Commit-Position: refs/heads/master@{#461447} Committed: https://chromium.googlesource.com/chromium/src/+/a0863c0a8a37eddf7d865636eb8d8ce9962a07bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M WATCHLISTS View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/geolocation/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Michael van Ouwerkerk
Tim, could you take a look please?
3 years, 1 month ago (2017-04-03 10:17:06 UTC) #4
timvolodine
lgtm
3 years, 1 month ago (2017-04-03 11:32:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794893002/1
3 years, 1 month ago (2017-04-03 12:00:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/400879)
3 years, 1 month ago (2017-04-03 12:06:54 UTC) #11
Michael van Ouwerkerk
Ted, could you please take a look for content/public/android/javatests/src/org/chromium/content/browser/OWNERS ?
3 years, 1 month ago (2017-04-03 12:32:04 UTC) #13
Ted C
lgtm
3 years, 1 month ago (2017-04-03 15:55:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2794893002/1
3 years, 1 month ago (2017-04-03 16:12:44 UTC) #16
commit-bot: I haz the power
3 years, 1 month ago (2017-04-03 16:20:26 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0863c0a8a37eddf7d865636eb8d...

Powered by Google App Engine
This is Rietveld 408576698